Skip to content

[interactive_media_ads] Updates README with information about enabling desugaring on Android #9790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Aug 12, 2025

Get started for IMA on Android includes enabling desugaring: https://developers.google.com/interactive-media-ads/docs/sdks/android/client-side/get-started#2.-add-the-ima-sdk-to-your-project

This updates the README for the plugin with the same information.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the package to include instructions and configuration for enabling core library desugaring on Android, which is a requirement for the IMA SDK. The changes include updating the README, the example app's Gradle file, and bumping the package version across relevant files.

My review has identified a few issues:

  • A minor typo in the CHANGELOG.md.
  • A broken link in the README.md to the Android developer documentation.
  • A potentially incorrect version for the desugar_jdk_libs dependency in both the README.md and the example's build.gradle. This is a high-priority issue as it could prevent users from successfully building their apps.

Please see the detailed comments for suggestions.

Comment on lines +60 to +62
`coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:2.1.5'` as a dependency in the
`android/app/build.gradle` file. For more details, see
[Java 11+ APIs available through desugaring with the nio specification](https://developer.android.com/studio/write/java11-nio-support-table).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The link to the Android developer documentation is broken, and the specified dependency version for desugar_jdk_libs appears to be incorrect.

  1. The link on line 62 is broken. A correct link for Java 8+ desugaring is https://developer.android.com/studio/write/java8-support#library-desugaring.
  2. The version 2.1.5 for com.android.tools:desugar_jdk_libs on line 60 is not available in public Google Maven repositories. The latest stable version is 2.0.4. Please verify the correct dependency artifact and version.

I've suggested updating both the dependency and the link.

Suggested change
`coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:2.1.5'` as a dependency in the
`android/app/build.gradle` file. For more details, see
[Java 11+ APIs available through desugaring with the nio specification](https://developer.android.com/studio/write/java11-nio-support-table).
`coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:2.0.4'` as a dependency in the
`android/app/build.gradle` file. For more details, see
[Java 8+ language features](https://developer.android.com/studio/write/java8-support#library-desugaring).

dependencies {
coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:2.1.5'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This dependency version 2.1.5 appears to be incorrect as it's not available in public repositories. Please verify the correct version. The latest known public version is 2.0.4.

    coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:2.0.4'

@@ -1,3 +1,7 @@
## 0.2.6+3

* Updates README with details about adding enabling desugarging on Android.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in the changelog entry. desugarging should be desugaring.

Suggested change
* Updates README with details about adding enabling desugarging on Android.
* Updates README with details about adding enabling desugaring on Android.

@bparrishMines bparrishMines changed the title update desugaring details [interactive_media_ads] Updates README with information about enabling desugaring on Android Aug 12, 2025
@bparrishMines bparrishMines marked this pull request as ready for review August 12, 2025 17:57
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2025
@auto-submit auto-submit bot merged commit 01d4c31 into flutter:main Aug 15, 2025
80 checks passed
@bparrishMines bparrishMines deleted the android_desugar branch August 15, 2025 19:46
CaoGiaHieu-dev added a commit to CaoGiaHieu-dev/packages that referenced this pull request Aug 18, 2025
* main: (24 commits)
  Roll Flutter from 0a2906b81d5e to b3fb4c786d80 (5 revisions) (flutter#9840)
  Update repo for 3.35 stable release (flutter#9816)
  Roll Flutter from 52af7a504025 to 0a2906b81d5e (16 revisions) (flutter#9836)
  [image_picker] Updates min SDK to 3.29 (flutter#9830)
  [image_picker] Add the ability to pick multiple videos (flutter#9775)
  [image_picker] Add the ability to pick multiple videos - platform implementations (flutter#9818)
  [various] Updates min SDK for third_party/packages to 3.29 (flutter#9819)
  [vector_graphics] Updates min SDK to 3.29 (flutter#9820)
  [google_maps_flutter] Updates min SDK to 3.29 (flutter#9821)
  [video_player] Updates min SDK to 3.29 (flutter#9826)
  [shared_preferences] Updates min SDK to 3.29 (flutter#9829)
  [image_picker_ios] Add photo to simulator Photos library during test (flutter#9759)
  [interactive_media_ads] Updates `README` with information about enabling desugaring on Android (flutter#9790)
  [in_app_purchase] Updates min SDK to 3.29 (flutter#9825)
  Roll Flutter from f4334d27934b to 52af7a504025 (29 revisions) (flutter#9832)
  [go_router] Update generated output format (flutter#9817)
  [video_player] Move Android buffer updates to Dart (flutter#9771)
  [webview_flutter] Add support for payment requests on Android (flutter#9679)
  [vector_graphics_compiler] Set the m4_10 (Z scale) value to 1 when constructing an AffineMatrix from an SVG matrix (flutter#9813)
  [url_launcher_ios] Fix test button text to work on iOS 26 (flutter#9766)
  ...

# Conflicts:
#	packages/go_router_builder/CHANGELOG.md
#	packages/go_router_builder/example/lib/all_types.g.dart
#	packages/go_router_builder/example/lib/main.g.dart
#	packages/go_router_builder/example/lib/shell_route_with_keys_example.g.dart
#	packages/go_router_builder/example/lib/shell_route_with_observers_example.g.dart
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 19, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Aug 19, 2025
flutter/packages@5c52c55...953cae0

2025-08-19 magder@google.com Add com.android.tools.build:gradle to
dependabot gradle-plugin group (flutter/packages#9848)
2025-08-19 stuartmorgan@google.com [flutter_migrate] Remove source
(flutter/packages#9847)
2025-08-18 lukas.mirbt1@gmail.com [go_router]: Add `RelativeGoRouteData`
and `TypedRelativeGoRoute` (flutter/packages#9732)
2025-08-18 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
edada7c to 20f8274 (1474 revisions) (flutter/packages#9837)
2025-08-18 engine-flutter-autoroll@skia.org Roll Flutter from
b3fb4c7 to 2265d94 (7 revisions) (flutter/packages#9845)
2025-08-18 stuartmorgan@google.com Disable SwiftPM for `xcode-analyze`
(flutter/packages#9666)
2025-08-17 engine-flutter-autoroll@skia.org Roll Flutter from
0a2906b to b3fb4c7 (5 revisions) (flutter/packages#9840)
2025-08-16 stuartmorgan@google.com Update repo for 3.35 stable release
(flutter/packages#9816)
2025-08-16 engine-flutter-autoroll@skia.org Roll Flutter from
52af7a5 to 0a2906b (16 revisions) (flutter/packages#9836)
2025-08-16 stuartmorgan@google.com [image_picker] Updates min SDK to
3.29 (flutter/packages#9830)
2025-08-16 stuartmorgan@google.com [image_picker] Add the ability to
pick multiple videos (flutter/packages#9775)
2025-08-16 stuartmorgan@google.com [image_picker] Add the ability to
pick multiple videos - platform implementations (flutter/packages#9818)
2025-08-16 stuartmorgan@google.com [various] Updates min SDK for
third_party/packages to 3.29 (flutter/packages#9819)
2025-08-16 stuartmorgan@google.com [vector_graphics] Updates min SDK to
3.29 (flutter/packages#9820)
2025-08-16 stuartmorgan@google.com [google_maps_flutter] Updates min SDK
to 3.29 (flutter/packages#9821)
2025-08-16 stuartmorgan@google.com [video_player] Updates min SDK to
3.29 (flutter/packages#9826)
2025-08-15 stuartmorgan@google.com [shared_preferences] Updates min SDK
to 3.29 (flutter/packages#9829)
2025-08-15 magder@google.com [image_picker_ios] Add photo to simulator
Photos library during test (flutter/packages#9759)
2025-08-15 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Updates `README` with information about enabling
desugaring on Android (flutter/packages#9790)
2025-08-15 stuartmorgan@google.com [in_app_purchase] Updates min SDK to
3.29 (flutter/packages#9825)
2025-08-15 engine-flutter-autoroll@skia.org Roll Flutter from
f4334d2 to 52af7a5 (29 revisions) (flutter/packages#9832)
2025-08-15 stuartmorgan@google.com [go_router] Update generated output
format (flutter/packages#9817)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
WillBLogical pushed a commit to WillBLogical/packages that referenced this pull request Aug 20, 2025
…ing desugaring on Android (flutter#9790)

Get started for IMA on Android includes enabling desugaring: https://developers.google.com/interactive-media-ads/docs/sdks/android/client-side/get-started#2.-add-the-ima-sdk-to-your-project

This updates the README for the plugin with the same information.

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: interactive_media_ads Plugin for IMA SDK platform-android platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants