fix: Android initialization bug and iOS 14 availability annotations #647
+31
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix Android PlatformException on first run after initialize (fixes #645) - Update currentDispatcherHandle when initialize() is called - Add validation for callback handle - Add iOS 14.0 availability annotation to LoggingDebugHandler (fixes #641) - Prevents build errors when os.Logger is used - Update documentation with iOS 14.0 minimum deployment target requirement (fixes #639) Co-Authored-By: Claude <noreply@anthropic.com>
|
To view this pull requests documentation preview, visit the following URL: docs.page/fluttercommunity/flutter_workmanager~647 Documentation is deployed and generated using docs.page. |
…ck handles The handle validation was too strict and incorrectly rejected valid callback handles (including 0) which caused all initialize calls to fail in integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #645, #641, #639
Closes #646, #642
Changes
Android Fix
currentDispatcherHandlewheninitialize()is called to prevent "You have not properly initialized" error on first runiOS Fix
@available(iOS 14.0, *)annotation toLoggingDebugHandlerclass that usesos.LoggerDocumentation
Credits
Test Plan