flux-job: remove cancel[all] subcommands #7058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Setting MWP |
|
I have a PR for the flux-pam usage of Currently the pr-validator is failing there, looking into it. |
Problem: flux job cancel[all] are being removed but still have tests. Drop the tests.
Problem: flux job cancel[all] have been deprecated in favor of flux cancel [--all] for a long time but still exist, leading to occasional confusion. Remove those subcommands. Fixes issue#7034
Problem: 'flux job cancel' was removed but job/cancel.c still exists, containing the 'kill' and 'raise' subcommands. Rename the source file to job/kill.c/
mergify
bot
force-pushed
the
issue#7034
branch
from
77f76ed to
316d221
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7058 +/- ##
==========================================
- Coverage 84.08% 84.07% -0.02%
==========================================
Files 549 549
Lines 92524 92461 -63
==========================================
- Hits 77802 77736 -66
- Misses 14722 14725 +3
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
flux job cancel[all]have been deprecated in favor offlux cancel [--all]for a long time but still exist, leading to occasional confusion.Remove those subcommands.
Fixes issue#7034