fixed cross join serialization #1459
Conversation
dev/statement_serializer.h
Outdated
| using statement_type = Join; | ||
|
|
||
| template<class Ctx> | ||
| SQLITE_ORM_STATIC_CALLOP std::string operator()(const statement_type& join, |
There was a problem hiding this comment.
Please comment out the unused join variable. I am getting frigthened by a lengthy warning message when compiling with warning level 4 :)
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
this Cursor ambush was unexpected and happened due to my GitHub connection with Cursor account. I did not explicitly asked Cursor to make reviews here, it is a result of their shitty marketing. I disabled connection with GitHub to prevent this in future. Sorry for that |
| std::string name; | ||
| }; | ||
| auto table = | ||
| make_virtual_table("users", using_fts5(make_column("id", &User::id), make_column("name", &User::name))); |
There was a problem hiding this comment.
Are you sure you want to make a virtual table?
There was a problem hiding this comment.
not at all. It was my blind copy-pasting technique. Let me fix it
There was a problem hiding this comment.
I think unit tests for natural joins are also appropriate?
There was a problem hiding this comment.
sure. I was thinking to skip it but you got me =)
There was a problem hiding this comment.
I think unit tests for natural joins are also appropriate?
cross_joinserialization and fixedcross_join.cppexamplecross_join_tto a dedicated file inastfolderis_cross_jointraitstatement_serializer@trueqbit probably I messed up with polyfill API - please feel free to add comments