refactor: updated and refactored for esm using latest npm libraries #11

timint · 2025-07-12T00:26:22Z

Leaving this library better than I found it.

Refactored for ESM
Updated and solved vulnerable dependencies
Updated build tools to latest config standards
Polished and modernized code where needed
Updated all tests to conform with new code

Benchmark results BEFORE:

Started: lookup
tangerine.lookup POST with caching using Cloudflare x 81.31 ops/sec ±195.93% (76 runs sampled)
tangerine.lookup POST without caching using Cloudflare x 155 ops/sec ±3.50% (70 runs sampled)
tangerine.lookup GET with caching using Cloudflare x 229,002 ops/sec ±2.29% (80 runs sampled)
tangerine.lookup GET without caching using Cloudflare x 200 ops/sec ±1.01% (77 runs sampled)
dns.promises.lookup with caching using Cloudflare x 9,104,364 ops/sec ±2.17% (77 runs sampled)
dns.promises.lookup without caching using Cloudflare x 4,753 ops/sec ±5.24% (72 runs sampled)
Fastest without caching is: dns.promises.lookup without caching using Cloudflare

Started: resolve
tangerine.resolve POST with caching using Cloudflare x 566 ops/sec ±195.91% (76 runs sampled)
tangerine.resolve POST without caching using Cloudflare x 178 ops/sec ±1.25% (75 runs sampled)
tangerine.resolve GET with caching using Cloudflare x 1,246,098 ops/sec ±1.70% (82 runs sampled)
tangerine.resolve GET without caching using Cloudflare x 173 ops/sec ±1.08% (71 runs sampled)
tangerine.resolve POST with caching using Google x 1,251,376 ops/sec ±1.57% (78 runs sampled)
tangerine.resolve POST without caching using Google x 107 ops/sec ±1.17% (75 runs sampled)
tangerine.resolve GET with caching using Google x 1,255,991 ops/sec ±2.21% (77 runs sampled)
tangerine.resolve GET without caching using Google x 110 ops/sec ±1.94% (80 runs sampled)
resolver.resolve with caching using Cloudflare x 7,586,061 ops/sec ±2.98% (71 runs sampled)
resolver.resolve without caching using Cloudflare x 206 ops/sec ±1.93% (72 runs sampled)
Fastest without caching is: resolver.resolve without caching using Cloudflare

Started: reverse
tangerine.reverse GET with caching x 553 ops/sec ±195.53% (73 runs sampled)
tangerine.reverse GET without caching x 195 ops/sec ±1.58% (74 runs sampled)
resolver.reverse with caching x 7,890,730 ops/sec ±3.13% (72 runs sampled)
resolver.reverse without caching x 202 ops/sec ±1.57% (69 runs sampled)
dns.promises.reverse with caching x 8,517,471 ops/sec ±1.42% (75 runs sampled)
dns.promises.reverse without caching x 205 ops/sec ±1.38% (71 runs sampled)
Fastest without caching is: dns.promises.reverse without caching, resolver.reverse without caching

Benchmark results AFTER:

Started: lookup
tangerine.lookup POST with caching using Cloudflare x 584 ops/sec ±195.45% (73 runs sampled)
tangerine.lookup POST without caching using Cloudflare x 182 ops/sec ±1.79% (73 runs sampled)
tangerine.lookup GET with caching using Cloudflare x 224,403 ops/sec ±1.46% (83 runs sampled)
tangerine.lookup GET without caching using Cloudflare x 186 ops/sec ±1.28% (70 runs sampled)
dns.promises.lookup with caching using Cloudflare x 9,039,409 ops/sec ±4.04% (73 runs sampled)
dns.promises.lookup without caching using Cloudflare x 4,767 ops/sec ±5.99% (73 runs sampled)
Fastest without caching is: dns.promises.lookup without caching using Cloudflare

Started: resolve
tangerine.resolve POST with caching using Cloudflare x 664 ops/sec ±195.89% (79 runs sampled)
tangerine.resolve POST without caching using Cloudflare x 202 ops/sec ±1.88% (71 runs sampled)
tangerine.resolve GET with caching using Cloudflare x 1,226,500 ops/sec ±1.50% (79 runs sampled)
tangerine.resolve GET without caching using Cloudflare x 180 ops/sec ±1.35% (75 runs sampled)
tangerine.resolve POST with caching using Google x 1,212,057 ops/sec ±1.55% (81 runs sampled)
tangerine.resolve POST without caching using Google x 111 ops/sec ±1.98% (72 runs sampled)
tangerine.resolve GET with caching using Google x 1,197,579 ops/sec ±2.44% (78 runs sampled)
tangerine.resolve GET without caching using Google x 111 ops/sec ±0.62% (78 runs sampled)
resolver.resolve with caching using Cloudflare x 7,879,187 ops/sec ±2.90% (74 runs sampled)
resolver.resolve without caching using Cloudflare x 215 ops/sec ±1.42% (76 runs sampled)
Fastest without caching is: resolver.resolve without caching using Cloudflare

Started: reverse
tangerine.reverse GET with caching x 619 ops/sec ±195.69% (78 runs sampled)
tangerine.reverse GET without caching x 198 ops/sec ±1.17% (76 runs sampled)
resolver.reverse with caching x 8,534,229 ops/sec ±1.67% (77 runs sampled)
resolver.reverse without caching x 212 ops/sec ±1.40% (75 runs sampled)
dns.promises.reverse with caching x 8,404,110 ops/sec ±1.74% (76 runs sampled)
dns.promises.reverse without caching x 211 ops/sec ±1.22% (73 runs sampled)
Fastest without caching is: resolver.reverse without caching, dns.promises.reverse without caching

…sions to date

socket-security · 2025-07-12T00:28:09Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Quality	Maintenance	License
is-ci@3.0.1 ⏵ 4.1.0	⁺¹	⁺²
dohdec@5.0.3 ⏵ 7.0.4	⁺¹	⁺³		⁺³¹
is-stream@3.0.0 ⏵ 4.0.1	⁺¹
p-wait-for@3.2.0 ⏵ 5.0.2	⁺¹	⁺¹³
auto-bind@4.0.0 ⏵ 5.0.1
sort-keys@4.2.0 ⏵ 5.1.0		^-4
p-map@5.5.0 ⏵ 7.0.3	⁺¹	⁺¹
get-stream@8.0.1 ⏵ 9.0.1		⁺¹
fetch-mock@10.1.1 ⏵ 12.5.3	⁺¹	^-12	^-3
remark-cli@11.0.0 ⏵ 12.0.1		⁺¹
got@14.4.7
cross-env@7.0.3 ⏵ 10.0.0
port-numbers@6.0.1 ⏵ 8.0.28		^-1	^-3
ava@5.3.1 ⏵ 6.4.1	⁺¹
lint-staged@15.5.2 ⏵ 16.1.5	⁺¹
superagent@9.0.2 ⏵ 10.2.3	⁺¹		⁺¹
nock@13.5.6 ⏵ 14.0.10			⁺²

View full report

index.js

+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);


index.js

+// Dynamically import dohdec
 let dohdec;
 // eslint-disable-next-line unicorn/prefer-top-level-await
-import('dohdec').then((obj) => {
-  dohdec = obj;
+import('dohdec').then((object) => {
+  dohdec = object;
 });


titanism · 2025-08-20T20:26:10Z

Agreed, we are CJS only here. Additionally I'm wondering why the staggering test benchmark differences. Doesn't seem accurate. What was the underlying package or change that brought the differences?

timint · 2025-08-21T00:13:45Z

Feel free to do what you want with it. I have no more use for it. I turned down paid assignments to play with this. And considering that my time invested, and sharing the work seemed to upset people here. I'm not interested in providing any more of my time.

you are creating shit loads of un-necessary format changes.

That's an absolute dick comment. Are you trying to be productive with that attitude? Go wash your mouth.

timint · 2025-08-21T00:25:27Z

You gotta try something, and I don't think attitude is gonna get you far.

titanism · 2025-08-21T00:30:47Z

I'm not sure who @SukkaW is but we've banned them. Apologies that other users gave negative comments to your positive PR. My only question was what was the source do you think for the benchmark differences. 😄

banned

timint · 2025-08-21T01:18:16Z

Thank you @titanism . I think you did the right thing and everyone a favour.

So, my time doing this was limited and I didn't upscale the amount of work I put in. I'm sharing the work as-is hoping it might save someone time. I don't mind if you wanna make some adjustments before adopting, it or just use bits and pieces. I see projects commonly moving towards ESM and I think libraries are future proof that way. But I agree they should be backwards compatible with CommonJS and that needs to be added to this PR.

The tests were both carried out from my local machine. One for the PR and one for 1.6.0. I would recommend anyone to run their own tests, multiple times to get some kind of average. What's key here is the results are unique to the machine running it.

The main reason I refactored this was due to the high amount of vulnerable and abandoned libraries it included.

refactor: updated and refactored for esm using latest npm library ver…

553ebf5

…sions to date

SukkaW suggested changes Aug 20, 2025

View reviewed changes

This comment was marked as abuse.

Sign in to view

titanism closed this Aug 20, 2025

titanism reopened this Aug 20, 2025

timint requested a review from SukkaW August 20, 2025 23:55

timint added 2 commits August 21, 2025 05:04

refactor: more refactoring (eslint, xo, imports etc)

a37ad7a

chore: update npm libraries to latest versions

dbfc341

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: updated and refactored for esm using latest npm libraries #11

refactor: updated and refactored for esm using latest npm libraries #11

Uh oh!

timint commented Jul 12, 2025

Uh oh!

socket-security bot commented Jul 12, 2025 •

edited

Loading

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

titanism commented Aug 20, 2025

Uh oh!

timint commented Aug 21, 2025

Uh oh!

timint commented Aug 21, 2025

Uh oh!

titanism commented Aug 21, 2025

Uh oh!

timint commented Aug 21, 2025

Uh oh!

Uh oh!

		const __filename = fileURLToPath(import.meta.url);
		const __dirname = path.dirname(__filename);

refactor: updated and refactored for esm using latest npm libraries #11

Are you sure you want to change the base?

refactor: updated and refactored for esm using latest npm libraries #11

Uh oh!

Conversation

timint commented Jul 12, 2025

Uh oh!

socket-security bot commented Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

titanism commented Aug 20, 2025

Uh oh!

timint commented Aug 21, 2025

Uh oh!

timint commented Aug 21, 2025

Uh oh!

titanism commented Aug 21, 2025

Uh oh!

timint commented Aug 21, 2025

Uh oh!

Uh oh!

socket-security bot commented Jul 12, 2025 •

edited

Loading