Skip to content

Conversation

AsCress
Copy link
Collaborator

@AsCress AsCress commented Sep 24, 2025

Fixes #2899
Adds pin layouts for PSLab V5 and V6.

Summary by Sourcery

Introduce front/back pin layout support by adding stub screen, menu options, and localization entries.

New Features:

  • Add PinLayoutScreen stub to display pin layouts
  • Add "Pin Layout Front" and "Pin Layout Back" options to the app bar menu

Enhancements:

  • Inject AppLocalizations via the service locator in MainScaffold

Documentation:

  • Add localization keys pinLayoutFront and pinLayoutBack and translations across all supported locales

@AsCress AsCress self-assigned this Sep 24, 2025
@AsCress AsCress added Feature New addition to the existing app flutter labels Sep 24, 2025
Copy link
Contributor

sourcery-ai bot commented Sep 24, 2025

Reviewer's Guide

Introduces a pin layout feature by adding a popup menu in the app bar to select front/back layouts, defines new localization keys for these options in all supported languages, and scaffolds a placeholder screen for the pin layout.

File-Level Changes

Change Details Files
Replace hardcoded menu icon with a localized popup menu for pin layout selection
  • Import AppLocalizations and locator
  • Retrieve AppLocalizations instance via getIt
  • Swap IconButton for PopupMenuButton with pinLayoutFront and pinLayoutBack items
lib/view/widgets/main_scaffold_widget.dart
Add new localization keys for pin layout labels
  • Declare pinLayoutFront and pinLayoutBack in AppLocalizations base
  • Implement getters in each language-specific file
lib/l10n/app_localizations.dart
lib/l10n/app_localizations_de.dart
lib/l10n/app_localizations_en.dart
lib/l10n/app_localizations_es.dart
lib/l10n/app_localizations_fr.dart
lib/l10n/app_localizations_he.dart
lib/l10n/app_localizations_hi.dart
lib/l10n/app_localizations_id.dart
lib/l10n/app_localizations_ja.dart
lib/l10n/app_localizations_nb.dart
lib/l10n/app_localizations_pt.dart
lib/l10n/app_localizations_ru.dart
lib/l10n/app_localizations_uk.dart
lib/l10n/app_localizations_vi.dart
lib/l10n/app_localizations_zh.dart
Scaffold a new PinLayoutScreen widget
  • Create PinLayoutScreen StatefulWidget
  • Add empty Container in build method
lib/view/pin_layout_screen.dart

Assessment against linked issues

Issue Objective Addressed Explanation
#2899 Fix the top right 3-dot dropdown so that it works on Android.
#2899 Show a dropdown with the different available hardware versions of PSLab with front and back options.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

github-actions bot commented Sep 24, 2025

Build Status

Build successful. APKs to test: https://github.com/fossasia/pslab-app/actions/runs/18295197597/artifacts/4197519974.

Screenshots

Android Screenshots
iPhone Screenshots
iPad Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New addition to the existing app flutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top right 3dot dropdown not working
2 participants