Skip to content

refactor(verify): remove redundant logging in Etherscan provider #11048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 14, 2025
Merged

refactor(verify): remove redundant logging in Etherscan provider #11048

merged 9 commits into from
Aug 14, 2025

Conversation

crStiv
Copy link
Contributor

@crStiv crStiv commented Jul 19, 2025

Removed redundant warn!/error! calls to reduce log noise and improve clarity

mattsse
mattsse requested changes Jul 24, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense, but there's no need to put changes as docs

@crStiv
Copy link
Contributor Author

crStiv commented Jul 26, 2025

this makes sense, but there's no need to put changes as docs

tnx for the review, does it make sense now?

@crStiv crStiv requested a review from mattsse July 26, 2025 15:14
kaxhnet
kaxhnet previously approved these changes Jul 26, 2025
View reviewed changes
Copy link

@kaxhnet kaxhnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lsh9

mattsse
mattsse requested changes Jul 27, 2025
View reviewed changes
@crStiv crStiv requested a review from mattsse July 27, 2025 15:51
zerosnacks
zerosnacks reviewed Aug 5, 2025
View reviewed changes
zerosnacks
zerosnacks reviewed Aug 5, 2025
View reviewed changes
crStiv and others added 2 commits August 5, 2025 20:21
@crStiv @zerosnacks
Update crates/verify/src/etherscan/mod.rs
7ac996e 
Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
@crStiv @zerosnacks
Update crates/verify/src/etherscan/mod.rs
92d0385 
Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
@crStiv crStiv requested a review from zerosnacks August 5, 2025 18:29
DaniPopes
DaniPopes previously approved these changes Aug 12, 2025
View reviewed changes
@DaniPopes DaniPopes enabled auto-merge (squash) August 12, 2025 09:46
@DaniPopes DaniPopes merged commit f50769f into foundry-rs:master Aug 14, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

+1 more reviewer

@kaxhnet kaxhnet kaxhnet left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@crStiv @mattsse @grandizzy @DaniPopes @zerosnacks @kaxhnet