Skip to content

Improve design of "Use on OS" pages #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Conversation

IanWitham
Copy link
Contributor

Enhance the layout and visual elements of the three "Use on OS" pages to improve user experience and readability. This includes the addition of updated SVG icons and a more structured presentation of installation options (similar to "books" page).

There are other pages that can probably do with the same treatment.

Copy link
Contributor Author

@IanWitham IanWitham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Markdown Lint check seems to be a bit too strict :(

@bbatsov
Copy link
Contributor

bbatsov commented Apr 18, 2025

We should probably increase the line-length limit to 100-120 and allow inline HTML, as we used them a lot. The other problems it flagged seem legit to me.

@bbatsov
Copy link
Contributor

bbatsov commented Apr 18, 2025

(it was my intention to gradually improve the markdown style every time we edit some files, that's why the linter checks only the edited files within a PR)

@bbatsov
Copy link
Contributor

bbatsov commented Apr 18, 2025

I've also noticed that something's wrong with the configuration detection, as I've actually disabled the inline HTML check and bumped the line-length (see https://github.com/fsharp/fsharp.org/blob/main/.markdownlint-cli2.jsonc), but for some reason the config is ignored. I'll look into this.

@bbatsov
Copy link
Contributor

bbatsov commented Apr 22, 2025

@IanWitham Fixed in #1001.

@dsyme dsyme merged commit 9bdf6f9 into fsharp:main Apr 22, 2025
1 check failed
@IanWitham IanWitham deleted the use-on-OS-formatting branch April 23, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants