-
Notifications
You must be signed in to change notification settings - Fork 2
Added configurable options #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,15 +2,15 @@ import typescript from 'rollup-plugin-typescript2'; | |
import pkg from './package.json'; | ||
import { terser } from 'rollup-plugin-terser'; | ||
import bundleSize from 'rollup-plugin-bundle-size'; | ||
import path from "path"; | ||
|
||
export default { | ||
input: 'src/index.ts', | ||
output: [ | ||
{ | ||
file: pkg.main, | ||
format: 'cjs', | ||
sourcemap: true | ||
sourcemap: true, | ||
exports: 'default' | ||
}, | ||
{ | ||
file: pkg.module, | ||
|
@@ -21,9 +21,6 @@ export default { | |
external: [ | ||
...Object.keys(pkg.dependencies || {}) | ||
], | ||
alias: { | ||
'@/': path.resolve(__dirname, '/src/') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ts takes care of this |
||
}, | ||
plugins: [ | ||
typescript({ | ||
typescript: require('typescript'), | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,30 @@ | ||
/* eslint-disable @typescript-eslint/no-unsafe-member-access */ | ||
import { can, cannot, has, hasnt } from './lib/Directives'; | ||
import type { App } from '@vue/runtime-core'; | ||
import type { Config } from '../types/config'; | ||
import type { Config, Directives } from '../types/config'; | ||
import ACL from './lib/ACL'; | ||
|
||
const defaults: Required<Config> = { | ||
roles: [], | ||
permissions: [], | ||
forceRemove: false, | ||
accessor: '$vacl', | ||
directives: { | ||
can: 'can', | ||
cannot: 'cannot', | ||
has: 'has', | ||
hasnt: 'hasnt' | ||
} as Required<Directives> | ||
}; | ||
|
||
export default { | ||
install: (app: App, options?: Config): void => { | ||
const acl = app.config.globalProperties.$vacl = new ACL(options); | ||
const directives = { ...defaults.directives, ...Object(options?.directives) }; | ||
const acl = app.config.globalProperties[options?.accessor ?? defaults.accessor] = new ACL(options); | ||
|
||
app.directive('can', can(acl)); | ||
app.directive('cannot', cannot(acl)); | ||
app.directive('has', has(acl)); | ||
app.directive('hasnt', hasnt(acl)); | ||
app.directive(directives.can, can(acl)); | ||
app.directive(directives.cannot, cannot(acl)); | ||
app.directive(directives.has, has(acl)); | ||
app.directive(directives.hasnt, hasnt(acl)); | ||
} | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import type ACL from '@/lib/ACL'; | ||
import type { VueWrapper } from '@vue/test-utils'; | ||
import { shallowMount } from '@vue/test-utils'; | ||
import { can, cannot, has, hasnt } from '@/lib/Directives'; | ||
|
||
/** | ||
* Create a test wrapper. | ||
* | ||
* @param {ACL} acl | ||
* @param {string} template | ||
* | ||
* @returns {VueWrapper<any>} | ||
*/ | ||
export function getWrapper(acl: ACL, template: string): VueWrapper<any> { | ||
return shallowMount({ template }, { | ||
global: { | ||
directives: { | ||
can: can(acl), | ||
cannot: cannot(acl), | ||
has: has(acl), | ||
hasnt: hasnt(acl) | ||
} | ||
} | ||
}); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,57 @@ | ||
import { mount } from '@vue/test-utils'; | ||
import { shallowMount, VueWrapper } from '@vue/test-utils'; | ||
import { createApp, h } from 'vue'; | ||
import ACL from '@/lib/ACL'; | ||
import Vacl from '@/index'; | ||
|
||
describe('reactivity', () => { | ||
describe('vue', () => { | ||
const component = { | ||
render() { | ||
return h('div'); | ||
} | ||
}; | ||
|
||
it('can be installed correctly', () => { | ||
const app = createApp({ | ||
template: '<div></div>' | ||
}).use(Vacl); | ||
const app = createApp(component).use(Vacl); | ||
|
||
expect(app.config.globalProperties.$vacl).toBeInstanceOf(ACL); | ||
}); | ||
|
||
it('provides the acl globally to all components', () => { | ||
const component = { | ||
render() { | ||
return h('div'); | ||
const wrapper = shallowMount(component, { | ||
global: { | ||
plugins: [[Vacl, { permissions: ['view'] }]] | ||
} | ||
}; | ||
}); | ||
|
||
expect(wrapper.vm.$vacl).toBeInstanceOf(ACL); | ||
expect(wrapper.vm.$vacl.can('view')).toBe(true); | ||
expect(wrapper.vm.$vacl.has('admin')).toBe(false); | ||
}); | ||
|
||
const app = mount(component, { | ||
it('should be able to configure global accessor name', () => { | ||
const wrapper = shallowMount(component, { | ||
global: { | ||
plugins: [[Vacl, { permissions: ['view'] }]] | ||
plugins: [[Vacl, { accessor: '$acl' }]] | ||
} | ||
}); | ||
|
||
expect(app.vm.$vacl).toBeInstanceOf(ACL); | ||
expect(app.vm.$vacl.can('view')).toBeTruthy(); | ||
expect(app.vm.$vacl.has('admin')).toBeFalsy(); | ||
expect(wrapper.vm.$acl).toBeInstanceOf(ACL); | ||
}); | ||
|
||
it('should be able to set the directive names from the config', () => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this needs to be tested for the other 3 directives as well |
||
const div = document.createElement('div'); | ||
div.id = 'id'; | ||
document.body.appendChild(div); | ||
|
||
const app = createApp({ | ||
template: `<div v-able="'view'" data-test='visible'></div> | ||
<div v-able="'edit'" data-test='hidden'></div>` | ||
}) | ||
.use(Vacl, { directives: { can: 'able' }, permissions: ['view'] }); | ||
|
||
const wrapper = new VueWrapper(app, app.mount('#id')); | ||
|
||
expect(wrapper.find('[data-test="visible"]').isVisible()).toBe(true); | ||
expect(wrapper.find('[data-test="hidden"]').isVisible()).toBe(false); | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rollup advised in the terminal so added itdocs