Use readlink to canonicalize path to script #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readlink without `-f` will return the relative value of the symlink and realpath will fail for values such as `../scm/repo/script.sh` when this is in `~/bin` and the script is called via the path. readlink will properly canonicalize the path when `-f` is specified, therefore just use it if available. readlink on MacOS does not support it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readlink without
-fwill return the relative value of the symlink andrealpath will fail for values such as
../scm/repo/script.shwhen thisis in
~/binand the script is called via the path. readlink willproperly canonicalize the path when
-fis specified, therefore justuse it.