Skip to content

Conversation

shameekganguly
Copy link
Contributor

@shameekganguly shameekganguly commented Jul 24, 2025

🎉 New feature

Summary

Extends RenderEngineManager to load a render engine plugin from the static plugin registry.

Also registered the default render engine plugins based on lookup in the plugin registry at runtime, in case one or more of the default render engines were statically linked in. This is required so that unloadEngine() can correctly unload the instantiated engine using the standard name, e.g. "ogre2". (Note: unloadEngine is called from the gz::sim::Sensors system). To make the plugin filename in the static plugin registry more obvious, I also added aliases for the existing render engine plugins with fully qualified names.

Test it

Added a test in the bazel build:

$ bazel test test:INTEGRATION_load_static_render_engine_plugin

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
@shameekganguly shameekganguly marked this pull request as ready for review July 24, 2025 07:03
@shameekganguly shameekganguly requested a review from iche033 as a code owner July 24, 2025 07:03
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jul 24, 2025
Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@iche033 iche033 requested a review from ahcorde July 24, 2025 20:43
@iche033 iche033 merged commit 3e695f9 into gz-rendering9 Jul 24, 2025
15 checks passed
@iche033 iche033 deleted the shameek/static_render_engine_clean branch July 24, 2025 22:28
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants