Add BOOTUP_B_DMG0 #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
reviewed
Aug 12, 2025
| @@ -1037,6 +1037,9 @@ def BOOTUP_A_MGB equ $FF | |||
| def BOOTUP_A_SGB equ BOOTUP_A_DMG | |||
| def BOOTUP_A_SGB2 equ BOOTUP_A_MGB | |||
|
|
|||
| ; Register B = CPU qualifier | |||
| def BOOTUP_B_DMG0 equ $FF | |||
There was a problem hiding this comment.
IMO group all the B values together:
; Register B = CPU qualifier
def BOOTUP_B_DMG0 equ $FF
def B_BOOTUP_B_AGB equ 0 ; applicable if A is BOOTUP_A_CGB
...There was a problem hiding this comment.
Sure, if you think it's cleaner that way.
|
Should anything else from https://gbdev.io/pandocs/Power_Up_Sequence.html#cpu-registers be added? |
Actually, a couple of things should be removed. |
|
Superseded by #75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.