Use Workpool for actions: enables retries & parallelism limits #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamwt
reviewed
Apr 4, 2025
There was a problem hiding this comment.
Meaning, you might want to highlight that benefit... it's obvious if you know convex, but reinforcing that idea here.
README.md
Outdated
| ### Specifying how many workflows can run in parallel | ||
|
|
||
| You can specify how many workflows can run in parallel by setting the `maxParallelism` | ||
| workpool option. This defaults to 50. |
There was a problem hiding this comment.
Is this more than can actually run on the free plan?
There was a problem hiding this comment.
I'll drop it to 25. Each of q/m/a/node action get 16. But on the free plan I suspect you won't struggle with huge scheduler backlog (and the scheduler is fair enough that you'll make progress, even if each new scheduler task might be behind 9 workflow tasks in the queue). lmk if you think a different default makes sense, but I don't want Pro customers to think it's slow by default b/c of throughput limits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the Workpool internally to handle durable action execution with retries
Fixes #7
Fixes #8
Fixes #18
Fixes #31
Fixes #24