Fix issues in discount

[ahmad753]

No description provided.

[alecritson]

Hi @ahmad753 I'm not sure this fixes anything, can you explain more what you're trying to solve?

[ahmad753]

@alecritson This commit "Fix basket line reward apply"
$reward->type the type is return like this "percentage_amount,fixed_amount or to_fixed_price"
and after using $method = 'apply'.ucfirst($reward->type);
it just appends "apply" then convert the first character to uppercase, and when checking the method exist it will return false, because the method variable value is applyPercentage_amout for i.e. which not exist.

And for this commit "Fix issues in discount" the removed line its not functioning, so I increment the discount from its set.

[bretto36]

Could you just change it to Str::camelCase and ucfirst so fixed_amount becomes FixedAmount?

[alecritson]

I think this would be better, although I appreciate this PR is quite old now so might need revisiting in full.