feat(install): Adds support for podman(compose) #3673
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| echo "${_group}Detecting container engine ..." | ||
|
|
||
| if [[ "${CONTAINER_ENGINE_PODMAN:-0}" -eq 1 ]] && command -v podman &>/dev/null; then | ||
| export CONTAINER_ENGINE="podman" | ||
| elif command -v docker &>/dev/null; then | ||
| export CONTAINER_ENGINE="docker" | ||
| else | ||
| echo "FAIL: Neither podman nor docker is installed on the system." | ||
| exit 1 | ||
| fi | ||
| echo "Detected container engine: $CONTAINER_ENGINE" | ||
| echo "${_endgroup}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,21 @@ | ||
| echo "${_group}Creating volumes for persistent storage ..." | ||
|
|
||
| create_volume() { | ||
| create_command="$CONTAINER_ENGINE volume create" | ||
| if [ "$CONTAINER_ENGINE" = "podman" ]; then | ||
| create_command="$create_command --ignore $1" | ||
| else | ||
| create_command="$create_command --name=$1" | ||
| fi | ||
|
|
||
| $create_command | ||
| } | ||
|
|
||
| echo "Created $(create_volume sentry-clickhouse)." | ||
| echo "Created $(create_volume sentry-data)." | ||
| echo "Created $(create_volume sentry-kafka)." | ||
| echo "Created $(create_volume sentry-postgres)." | ||
| echo "Created $(create_volume sentry-redis)." | ||
| echo "Created $(create_volume sentry-symbolicator)." | ||
|
|
||
| echo "${_endgroup}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,17 +6,27 @@ else | |
| _endgroup="" | ||
| fi | ||
|
|
||
| echo "${_group}Initializing Docker|Podman Compose ..." | ||
|
|
||
| export CONTAINER_ENGINE="docker" | ||
| if [[ "${CONTAINER_ENGINE_PODMAN:-0}" -eq 1 ]]; then | ||
| if command -v podman &>/dev/null; then | ||
| export CONTAINER_ENGINE="podman" | ||
| else | ||
| echo "FAIL: Podman is not installed on the system." | ||
| exit 1 | ||
| fi | ||
| fi | ||
|
|
||
| # To support users that are symlinking to docker-compose | ||
| dc_base="$(${CONTAINER_ENGINE} compose version --short &>/dev/null && echo "$CONTAINER_ENGINE compose" || echo '')" | ||
| dc_base_standalone="$(${CONTAINER_ENGINE}-compose version --short &>/dev/null && echo "$CONTAINER_ENGINE-compose" || echo '')" | ||
|
|
||
| COMPOSE_VERSION=$([ -n "$dc_base" ] && $dc_base version --short || echo '') | ||
| STANDALONE_COMPOSE_VERSION=$([ -n "$dc_base_standalone" ] && $dc_base_standalone version --short || echo '') | ||
|
|
||
| if [[ -z "$COMPOSE_VERSION" && -z "$STANDALONE_COMPOSE_VERSION" ]]; then | ||
| echo "FAIL: Docker|Podman Compose is required to run self-hosted" | ||
| exit 1 | ||
| fi | ||
|
|
||
|
|
@@ -25,14 +35,54 @@ if [[ -z "$COMPOSE_VERSION" ]] || [[ -n "$STANDALONE_COMPOSE_VERSION" ]] && ! ve | |
| dc_base="$dc_base_standalone" | ||
| fi | ||
|
|
||
| if [[ "$CONTAINER_ENGINE" == "docker" ]]; then | ||
| NO_ANSI="--ansi never" | ||
| elif [[ "$CONTAINER_ENGINE" == "podman" ]]; then | ||
| NO_ANSI="--no-ansi" | ||
| fi | ||
|
|
||
| if [[ "$(basename $0)" = "install.sh" ]]; then | ||
| dc="$dc_base $NO_ANSI --env-file ${_ENV}" | ||
| else | ||
| dc="$dc_base $NO_ANSI" | ||
| fi | ||
|
|
||
| proxy_args="--build-arg http_proxy=${http_proxy:-} --build-arg https_proxy=${https_proxy:-} --build-arg no_proxy=${no_proxy:-}" | ||
| if [[ "$CONTAINER_ENGINE" == "docker" ]]; then | ||
| proxy_args_dc=$proxy_args | ||
| dcr="$dc run --pull=never --rm" | ||
| elif [[ "$CONTAINER_ENGINE" == "podman" ]]; then | ||
| proxy_args_dc="--podman-build-args http_proxy=${http_proxy:-},https_proxy=${https_proxy:-},no_proxy=${no_proxy:-}" | ||
| dcr="$dc run --rm" | ||
| fi | ||
| dcb="$dc build $proxy_args" | ||
| dbuild="$CONTAINER_ENGINE build $proxy_args" | ||
|
|
||
| # Utility function to handle --wait with docker and podman | ||
| function start_service_and_wait_ready() { | ||
|
There was a problem hiding this comment. Well well... @aldy505 - with this, maybe we can lower the Docker Compose version requirement again as some people were complaining about that? There was a problem hiding this comment. Yes we might. Do you have any thoughts regarding this? @aminvakil |
||
| local options=() | ||
| local services=() | ||
| local found_service=0 | ||
|
|
||
| for arg in "$@"; do | ||
| if [[ $found_service -eq 0 && "$arg" == -* ]]; then | ||
| options+=("$arg") | ||
| else | ||
| found_service=1 | ||
| services+=("$arg") | ||
| fi | ||
| done | ||
|
|
||
| if [ "$CONTAINER_ENGINE" = "docker" ]; then | ||
| $dc up --wait "${options[@]}" "${services[@]}" | ||
| else | ||
| $dc up --force-recreate -d "${options[@]}" "${services[@]}" | ||
| for service in "${services[@]}"; do | ||
| while ! $CONTAINER_ENGINE ps --filter "health=healthy" | grep "$service"; do | ||
| sleep 2 | ||
| done | ||
| done | ||
| fi | ||
| } | ||
|
|
||
| echo "${_endgroup}" | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BYK I believe Docker and Docker Compose needs to be uninstalled if we want to move forward with this? Or we can just drop the Podman tests and do it on a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we have Podman, it takes precedence. Don't think we need to uninstall Docker. Why do you think so?