Add missing lib script to sentry-admin.sh #3693
Open
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BYK
requested changes
May 6, 2025
There was a problem hiding this comment.
Heya, thanks for the PR! That said I don't think _lib.sh is needed in this script. I haven't seen anything referring to that and we actually test the backup and restore functionality using this script.
Can you share what kind of an error you are encountering for us to understand this better?
|
Hey @BYK i got Issues that function vergte is unknow when ever I execute sentry-admin.sh no matter which parameter i add. After debugging I found that install/dc-detect-version.sh need this function. After fixing this locally, the script runs normaly. |
|
Ah, right sorry! Yeah, since that |
BYK
approved these changes
May 7, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry Admin Script always fail because of missing import of lib script.
Fixes #3700.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.