Support additional request data types in dio package
#3170
+802
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt into fix/dio-additional-request-data # Conflicts: # packages/dio/lib/src/dio_event_processor.dart
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3170 +/- ##
==========================================
+ Coverage 87.67% 87.80% +0.13%
==========================================
Files 291 291
Lines 9907 9956 +49
==========================================
+ Hits 8686 8742 +56
+ Misses 1221 1214 -7 ☔ View full report in Codecov by Sentry. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93b7728 | 475.28 ms | 489.13 ms | 13.86 ms |
| 0fb3800 | 465.64 ms | 536.77 ms | 71.13 ms |
| c1e775e | 482.36 ms | 608.98 ms | 126.62 ms |
| e2d675d | 457.92 ms | 529.17 ms | 71.25 ms |
| 9b99523 | 456.91 ms | 490.55 ms | 33.64 ms |
| 0929dbf | 462.82 ms | 492.76 ms | 29.94 ms |
| 7cfbbd6 | 499.69 ms | 592.24 ms | 92.55 ms |
| e45c0e1 | 447.29 ms | 558.33 ms | 111.04 ms |
| 2cf9161 | 454.12 ms | 512.67 ms | 58.55 ms |
| 0fb45d0 | 482.79 ms | 554.02 ms | 71.23 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 93b7728 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 0fb3800 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| c1e775e | 6.54 MiB | 7.70 MiB | 1.17 MiB |
| e2d675d | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 9b99523 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 0929dbf | 6.54 MiB | 7.70 MiB | 1.17 MiB |
| 7cfbbd6 | 6.54 MiB | 7.70 MiB | 1.17 MiB |
| e45c0e1 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| 2cf9161 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| 0fb45d0 | 6.54 MiB | 7.70 MiB | 1.17 MiB |
Previous results on branch: fix/dio-additional-request-data
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8359ad8 | 503.93 ms | 537.60 ms | 33.67 ms |
| 8cce66c | 469.73 ms | 489.08 ms | 19.35 ms |
| 6c23afe | 496.96 ms | 601.46 ms | 104.50 ms |
| 9d2f2ce | 571.00 ms | 606.26 ms | 35.26 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8359ad8 | 6.54 MiB | 7.70 MiB | 1.17 MiB |
| 8cce66c | 6.54 MiB | 7.70 MiB | 1.17 MiB |
| 6c23afe | 6.54 MiB | 7.70 MiB | 1.17 MiB |
| 9d2f2ce | 6.54 MiB | 7.70 MiB | 1.17 MiB |
|
Ok, we cannot tell at this point if |
|
Ok, seems to be an issue with the runner after all: |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eca355d | 1238.39 ms | 1266.98 ms | 28.59 ms |
| 79f6b41 | 1269.33 ms | 1279.71 ms | 10.38 ms |
| cc4e375 | 1253.06 ms | 1263.81 ms | 10.75 ms |
| 4481076 | 1256.48 ms | 1266.64 ms | 10.17 ms |
| 2d34233 | 1258.19 ms | 1268.92 ms | 10.73 ms |
| ec78888 | 1251.37 ms | 1269.40 ms | 18.04 ms |
| 0929dbf | 1275.89 ms | 1282.22 ms | 6.33 ms |
| 7cfee3b | 1260.90 ms | 1273.14 ms | 12.24 ms |
| 6ba4675 | 1223.12 ms | 1238.17 ms | 15.04 ms |
| 73dca78 | 1246.65 ms | 1265.42 ms | 18.76 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eca355d | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 79f6b41 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| cc4e375 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 4481076 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 2d34233 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| ec78888 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 0929dbf | 7.86 MiB | 9.54 MiB | 1.69 MiB |
| 7cfee3b | 20.70 MiB | 22.46 MiB | 1.75 MiB |
| 6ba4675 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 73dca78 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
Previous results on branch: fix/dio-additional-request-data
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6c23afe | 1272.27 ms | 1280.54 ms | 8.27 ms |
| 8359ad8 | 1253.20 ms | 1259.42 ms | 6.22 ms |
| 9d2f2ce | 1254.71 ms | 1269.79 ms | 15.08 ms |
| 8cce66c | 1258.14 ms | 1268.30 ms | 10.16 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6c23afe | 20.70 MiB | 22.46 MiB | 1.75 MiB |
| 8359ad8 | 20.70 MiB | 22.46 MiB | 1.75 MiB |
| 9d2f2ce | 20.70 MiB | 22.46 MiB | 1.75 MiB |
| 8cce66c | 20.70 MiB | 22.46 MiB | 1.75 MiB |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
buenaflor
reviewed
Aug 19, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
JSONList<int>num,boolFormDataMultipart💡 Motivation and Context
Closes #2982
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled