-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(nuxt): Parametrize routes on the server-side #16785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e9af3b
to
4e75465
Compare
s1gr1d
added a commit
that referenced
this pull request
Jul 8, 2025
While working on route parametrization, [it came up in this PR](#16785) that there are different transactions/spans which should be parametrized: - `pageload` transaction -> it's already parametrized because of the `vueIntegration` - SSR `http.server` transaction -> not parametrized - `http.client` span when doing an extra server request -> not parametrized - `http.server` span when doing an extra server request -> not parametrized This test is added to have a visualization of the current state of parametrization to be able to iterate on it. **The PR is quite long but the test case and the tests are just copy-pasted to all Nuxt E2E tests.**
chargome
reviewed
Jul 8, 2025
AbhiPrasad
approved these changes
Jul 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
none of my comments are blocking
AbhiPrasad
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds route parametrization for server API routes for production builds.
part of #16684