Skip to content

fix(browser): guard nextHopProtocol when adding resource spans #16900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025

Conversation

AbhiPrasad
Copy link
Member

ref #16804

This was addressed with #16806, but we didn't guard every location that uses entry.nextHopProtocol.

Will backport to v9 after merge.

@AbhiPrasad AbhiPrasad requested a review from a team July 10, 2025 14:51
@AbhiPrasad AbhiPrasad self-assigned this Jul 10, 2025
@AbhiPrasad AbhiPrasad requested review from mydea and s1gr1d and removed request for a team July 10, 2025 14:51
Copy link
Contributor

github-actions bot commented Jul 10, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.81 kB - -
@sentry/browser - with treeshaking flags 22.54 kB - -
@sentry/browser (incl. Tracing) 39.68 kB +0.02% +4 B 🔺
@sentry/browser (incl. Tracing, Replay) 77.8 kB +0.01% +6 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.74 kB +0.02% +7 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 82.49 kB +0.01% +6 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 94.61 kB +0.01% +5 B 🔺
@sentry/browser (incl. Feedback) 40.49 kB -0.01% -1 B 🔽
@sentry/browser (incl. sendFeedback) 28.5 kB - -
@sentry/browser (incl. FeedbackAsync) 33.39 kB -0.01% -1 B 🔽
@sentry/react 25.6 kB - -
@sentry/react (incl. Tracing) 41.66 kB +0.01% +3 B 🔺
@sentry/vue 28.27 kB - -
@sentry/vue (incl. Tracing) 41.48 kB +0.01% +4 B 🔺
@sentry/svelte 23.83 kB +0.01% +1 B 🔺
CDN Bundle 25.36 kB - -
CDN Bundle (incl. Tracing) 39.64 kB +0.02% +4 B 🔺
CDN Bundle (incl. Tracing, Replay) 75.58 kB +0.02% +8 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 81.03 kB +0.01% +6 B 🔺
CDN Bundle - uncompressed 74.08 kB - -
CDN Bundle (incl. Tracing) - uncompressed 117.73 kB +0.03% +28 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 231.65 kB +0.02% +28 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 244.46 kB +0.02% +28 B 🔺
@sentry/nextjs (client) 43.3 kB +0.01% +4 B 🔺
@sentry/sveltekit (client) 40.13 kB +0.02% +5 B 🔺
@sentry/node 167.87 kB - -
@sentry/node - without tracing 100.58 kB - -
@sentry/aws-serverless 128.7 kB - -

View base workflow run

Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@AbhiPrasad AbhiPrasad merged commit 6179229 into develop Jul 10, 2025
129 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-nextHopProtocol-browser-metrics branch July 10, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants