Skip to content

Deps: Update Kotlin to 2.1.21 #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Jul 18, 2025
Merged

Deps: Update Kotlin to 2.1.21 #389

merged 35 commits into from
Jul 18, 2025

Conversation

buenaflor
Copy link
Contributor

Kotlin 2.1.21 adds support for Xcode 16.3 and higher so this is important

Also update the compose version for the sample apps

@buenaflor buenaflor requested a review from romtsn as a code owner May 16, 2025 12:44
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.08%. Comparing base (f354280) to head (1915b7a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #389      +/-   ##
==========================================
- Coverage   78.29%   78.08%   -0.22%     
==========================================
  Files          44       44              
  Lines         834      835       +1     
  Branches      113      113              
==========================================
- Hits          653      652       -1     
- Misses        125      127       +2     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@buenaflor buenaflor marked this pull request as draft May 16, 2025 13:14
@buenaflor
Copy link
Contributor Author

Setting it to draft, lots of problems with the K2 compiler right now

Comment on lines 46 to -47
public var contexts: Map<String, Any> = mapOf()
internal set
Copy link
Contributor Author

@buenaflor buenaflor Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal set was what messed up the K2 compiler when compiling for native targets. admittedly I have no idea why but it compiles without it 😅

@@ -31,5 +30,5 @@ internal fun wrapUnhandledExceptionHook(hook: (Throwable) -> Unit) {
prevHook.value?.invoke(it)
terminateWithUnhandledException(it)
}
prevHook.value = setUnhandledExceptionHook(wrappedHook.freeze())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

freeze() is deprecated / not needed anymore in this kotlin version

@buenaflor buenaflor marked this pull request as ready for review June 28, 2025 12:52
@buenaflor
Copy link
Contributor Author

@romtsn ready for review when you hve time 🙏

@buenaflor
Copy link
Contributor Author

buenaflor commented Jul 16, 2025

Just noticed that this messes up publication as K2 produces the output of .klib files a bit differently. will adjust the PR

new publication impl has been added

buenaflor and others added 6 commits July 16, 2025 12:04
…lishToMavenLocal` (#425)

* Update

* Update

* Update

* Let CI run for testing

* Update

* Update

* Update

* Update

* Update

* Clean up

* Update use maybeCreate always
@buenaflor buenaflor merged commit 9785d1a into main Jul 18, 2025
9 checks passed
@buenaflor buenaflor deleted the deps/upgrade-kotlin branch July 18, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants