Removes temporary flags after Cocoa Bump #5038

antonis · 2025-07-31T14:58:56Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

Based on #5036

📜 Description

Removes temporary flags after Cocoa Bump and updates the sample app native initialisation example

The fixes in this PR are needed for the Cocoa ~~8.54~~ 8.55 bump #5036

💡 Motivation and Context

fixes #5022

💚 How did you test it?

Manual, CI

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

github-actions · 2025-07-31T15:22:44Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	430.41 ms	413.66 ms	-16.75 ms
Size	17.75 MiB	20.15 MiB	2.41 MiB

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision	Plain	With Sentry	Diff
`f9bd7d3`	403.74 ms	385.54 ms	-18.20 ms
`f139dae`	415.36 ms	400.73 ms	-14.63 ms
`6c67a16`	442.07 ms	454.91 ms	12.84 ms
`ba483fc`	407.51 ms	398.52 ms	-8.99 ms

App size

Revision	Plain	With Sentry	Diff
`f9bd7d3`	17.75 MiB	20.15 MiB	2.41 MiB
`f139dae`	17.75 MiB	20.15 MiB	2.40 MiB
`6c67a16`	17.75 MiB	20.15 MiB	2.40 MiB
`ba483fc`	17.75 MiB	20.15 MiB	2.40 MiB

github-actions · 2025-07-31T15:42:43Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	359.86 ms	430.55 ms	70.69 ms
Size	7.15 MiB	8.42 MiB	1.27 MiB

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision	Plain	With Sentry	Diff
`f139dae`+dirty	383.66 ms	389.28 ms	5.62 ms
`f9bd7d3`+dirty	403.83 ms	442.76 ms	38.92 ms
`ba483fc`+dirty	432.91 ms	454.14 ms	21.23 ms
`6c67a16`+dirty	408.86 ms	440.96 ms	32.10 ms

App size

Revision	Plain	With Sentry	Diff
`f139dae`+dirty	7.15 MiB	8.42 MiB	1.26 MiB
`f9bd7d3`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`ba483fc`+dirty	7.15 MiB	8.42 MiB	1.26 MiB
`6c67a16`+dirty	7.15 MiB	8.42 MiB	1.26 MiB

antonis · 2025-07-31T16:06:20Z

I'll need to investigate the CI failure in older RN. From the logs (see below) it might be related to getsentry/sentry-cocoa#5604

Error: reference to property 'videoWriter' in closure requires explicit use of 'self' to make capture semantics explicit
            SentrySDKLog.debug("[Session Replay] Finished video writing, status: \(videoWriter.status)")
                                                                                   ^
Error: reference to property 'videoWriter' in closure requires explicit use of 'self' to make capture semantics explicit
                SentrySDKLog.warning("[Session Replay] Finish writing video failed, reason: \(String(describing: videoWriter.error))")
                                                                                                                 ^
Error: reference to property 'videoWriter' in closure requires explicit use of 'self' to make capture semantics explicit
                SentrySDKLog.warning("[Session Replay] Finish writing video with unknown status, reason: \(String(describing: videoWriter.error))")
                                                                                                                              ^
Error: reference to property 'videoWriter' in closure requires explicit use of 'self' to make capture semantics explicit
                SentrySDKLog.warning("[Session Replay] Finish writing video in unknown state, reason: \(String(describing: videoWriter.error))")
                                                                                                                           ^
Error: reference to property 'videoWriter' in closure requires explicit use of 'self' to make capture semantics explicit
            switch videoWriter.status {
                   ^
Error: reference to property 'outputFileURL' in closure requires explicit use of 'self' to make capture semantics explicit
                        from: outputFileURL,
                              ^
Error: reference to property 'usedFrames' in closure requires explicit use of 'self' to make capture semantics explicit
                        usedFrames: usedFrames,
                                    ^
Error: reference to property 'videoWidth' in closure requires explicit use of 'self' to make capture semantics explicit
                        videoWidth: Int(videoWidth),
                                        ^
Error: reference to property 'videoHeight' in closure requires explicit use of 'self' to make capture semantics explicit
                        videoHeight: Int(videoHeight)
                                         ^
Error: reference to property 'videoWriter' in closure requires explicit use of 'self' to make capture semantics explicit
                completion(.failure(videoWriter.error ?? SentryOnDemandReplayError.errorRenderingVideo))
                                    ^
Error: reference to property 'videoWriter' in closure requires explicit use of 'self' to make capture semantics explicit
                completion(.failure(videoWriter.error ?? SentryOnDemandReplayError.errorRenderingVideo))

…_flags

This reverts commit c59bb69.

This reverts commit 54af75e.

…_flags

github-actions · 2025-08-14T06:04:37Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1224.83 ms	1241.40 ms	16.57 ms
Size	3.19 MiB	4.42 MiB	1.23 MiB

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision	Plain	With Sentry	Diff
`6c67a16`+dirty	1220.52 ms	1223.47 ms	2.95 ms
`f9bd7d3`+dirty	1224.46 ms	1237.04 ms	12.58 ms
`ba483fc`+dirty	1203.07 ms	1213.62 ms	10.55 ms
`f139dae`+dirty	1213.82 ms	1215.87 ms	2.05 ms

App size

Revision	Plain	With Sentry	Diff
`6c67a16`+dirty	3.19 MiB	4.35 MiB	1.16 MiB
`f9bd7d3`+dirty	3.19 MiB	4.38 MiB	1.19 MiB
`ba483fc`+dirty	3.19 MiB	4.35 MiB	1.17 MiB
`f139dae`+dirty	3.19 MiB	4.36 MiB	1.17 MiB

github-actions · 2025-08-14T06:05:27Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1228.39 ms	1234.96 ms	6.57 ms
Size	2.63 MiB	3.85 MiB	1.22 MiB

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision	Plain	With Sentry	Diff
`6c67a16`+dirty	1218.27 ms	1224.22 ms	5.96 ms
`f9bd7d3`+dirty	1207.15 ms	1216.72 ms	9.57 ms
`ba483fc`+dirty	1211.24 ms	1220.49 ms	9.24 ms
`f139dae`+dirty	1220.86 ms	1233.21 ms	12.35 ms

App size

Revision	Plain	With Sentry	Diff
`6c67a16`+dirty	2.63 MiB	3.78 MiB	1.15 MiB
`f9bd7d3`+dirty	2.63 MiB	3.81 MiB	1.18 MiB
`ba483fc`+dirty	2.63 MiB	3.78 MiB	1.15 MiB
`f139dae`+dirty	2.63 MiB	3.80 MiB	1.17 MiB

antonis · 2025-08-14T06:58:27Z

0.65.3 build issues are fixed in 8.55.0 with getsentry/sentry-cocoa#5917

…_flags

alwx · 2025-08-14T13:31:09Z

samples/react-native/ios/SentryNativeInitialiser.m

+#import "SentryNativeInitialiser.h"
+@import Sentry;
+
+@implementation SentryNativeInitialiser


A minor thing: probably it needs to be called SentryNativeInitialiser with z for the sake of consistency with other function names in Sentry SDKs and with the function name (void)initializeSentry below.

Well done! I wouldn't have noticed that nit

Good catch @alwx 🙇
Updated with 29f79b9

CHANGELOG.md

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>

alwx

🚀

packages/core/ios/RNSentry.mm

lucas-zimerman

LGTM!

Checked the previous PRs that added those conditions and everything was correctly reverted to the new pattern.

antonis · 2025-08-14T15:01:05Z

Marking this as blocked for now since I've noticed another CI failure (not in 0.65.3)

[Sentry] Compiling SentrySDK.swift
Error: incorrect argument label in call (have 'userFeedback:', expected 'error:')
        SentrySDKInternal.capture(userFeedback: userFeedback)
                                 ^~~~~~~~~~~~~
Error: 'UserFeedback' is not convertible to 'any Error'
        SentrySDKInternal.capture(userFeedback: userFeedback)
                                                ^
Error: Process completed with exit code 65.

This should be related with the changes in here

I haven't been able to reproduce locally yet.

…_flags

web-flow and others added 3 commits July 31, 2025 13:59

chore: update scripts/update-cocoa.sh to 8.54.0

6b7aad8

Remove Cocoa Flags

83f91bb

Update sample app native initialisation example

8ae835d

antonis requested a review from noahsmartin July 31, 2025 14:59

Remove unused imports

702b2fc

antonis mentioned this pull request Jul 31, 2025

Rollback Cocoa 8.53.2 workaround #5039

Draft

10 tasks

chore: update scripts/update-cocoa.sh to 8.54.0

ed6a296

bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from 6b7aad8 to ed6a296 Compare August 5, 2025 12:21

Merge branch 'deps/scripts/update-cocoa.sh' into antonis/remove_cocoa…

1d95a86

…_flags

bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from ed6a296 to 32140fd Compare August 5, 2025 14:05

antonis mentioned this pull request Aug 5, 2025

fix(react-native): Fixes React Native closure compilation issue getsentry/sentry-cocoa#5816

Merged

7 tasks

bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from 32140fd to d337b46 Compare August 5, 2025 15:32

antonis added 4 commits August 6, 2025 11:10

Test with cocoa fix

54af75e

Trigger CI

c59bb69

Revert "Trigger CI"

a67956f

This reverts commit c59bb69.

Revert "Test with cocoa fix"

d6c0afc

This reverts commit 54af75e.

antonis mentioned this pull request Aug 6, 2025

chore(deps): update Cocoa SDK to v8.55.0 #5036

Open

bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch 10 times, most recently from c8265df to 5cbd8dc Compare August 11, 2025 14:10

bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch 3 times, most recently from 27b0d6d to d2f6a18 Compare August 13, 2025 14:58

antonis and others added 3 commits August 13, 2025 20:58

Test with 8.54.1-apha.2

3d17397

trigger ci

4ea0cda

chore: update scripts/update-cocoa.sh to 8.55.0

4f3abd3

bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from d2f6a18 to 4f3abd3 Compare August 14, 2025 03:26

Merge branch 'deps/scripts/update-cocoa.sh' into antonis/remove_cocoa…

584af1e

…_flags

chore: update scripts/update-cocoa.sh to 8.55.0

dcd3b15

bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from 4f3abd3 to dcd3b15 Compare August 14, 2025 12:16

Merge branch 'deps/scripts/update-cocoa.sh' into antonis/remove_cocoa…

5124b3c

…_flags

antonis marked this pull request as ready for review August 14, 2025 12:44

antonis requested review from alwx and lucas-zimerman as code owners August 14, 2025 12:44

alwx requested changes Aug 14, 2025

View reviewed changes

lucas-zimerman reviewed Aug 14, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

antonis and others added 2 commits August 14, 2025 16:38

Remove duplicate changelog

4b795ed

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>

ref: Rename SentryNativeInitialiser to SentryNativeInitializer

29f79b9

alwx self-requested a review August 14, 2025 13:47

alwx approved these changes Aug 14, 2025

View reviewed changes

lucas-zimerman reviewed Aug 14, 2025

View reviewed changes

packages/core/ios/RNSentry.mm Show resolved Hide resolved

lucas-zimerman approved these changes Aug 14, 2025

View reviewed changes

Revert unneeded changes

c3af0db

antonis added the Blocked label Aug 14, 2025

bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from dcd3b15 to 61df9c3 Compare August 14, 2025 15:43

Merge branch 'deps/scripts/update-cocoa.sh' into antonis/remove_cocoa…

5dc8855

…_flags

Uh oh!

Removes temporary flags after Cocoa Bump #5038

Are you sure you want to change the base?

Removes temporary flags after Cocoa Bump #5038

Uh oh!

Conversation

antonis commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

App size

Uh oh!

github-actions bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

App size

Uh oh!

antonis commented Jul 31, 2025

Uh oh!

github-actions bot commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

App size

Uh oh!

github-actions bot commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

App size

Uh oh!

antonis commented Aug 14, 2025

Uh oh!

alwx Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

lucas-zimerman Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

antonis Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alwx left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

antonis commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

antonis commented Jul 31, 2025 •

edited

Loading

github-actions bot commented Jul 31, 2025 •

edited

Loading

github-actions bot commented Jul 31, 2025 •

edited

Loading

github-actions bot commented Aug 14, 2025 •

edited

Loading

github-actions bot commented Aug 14, 2025 •

edited

Loading

antonis commented Aug 14, 2025 •

edited

Loading