Map trilogy
database adapter to mysql
for Query Insights compatibility
#2656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
trilogy
adapter in Rails app, Query Insights view in Sentry did not show any data.The problem is that
trilogy
is not in the allowed system db name list:https://github.com/getsentry/semantic-conventions/blob/main/docs/attributes-registry/db.md
despite being just a different MySQL adapter, and hence does not meet the criteria for span eligibility:
https://docs.sentry.io/product/insights/backend/queries/#span-eligibility
The simple fix is to just map
trilogy
tomysql
for the db system name.Current Behavior
No query data is displayed because
trilogy
is not recognized as a valid database system.Expected Behavior
Query data from
trilogy
adapter should appear in Sentry's Query Insights view, similar to other MySQL adapters.Alternative solution (how I tested it worked)
The same result can be achieved using
before_send_transaction
: