Skip to content

Fix console tracing #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix console tracing #930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/EventListener/TracingConsoleListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,12 @@
return;
}

$span = $this->hub->getSpan();
$transaction = $this->hub->getTransaction();

if (null !== $span) {
$span->setStatus(0 === $event->getExitCode() ? SpanStatus::ok() : SpanStatus::internalError());
$span->finish();
if (null !== $transaction) {
$transaction->setStatus(0 === $event->getExitCode() ? SpanStatus::ok() : SpanStatus::internalError());
$transaction->finish();
metrics()->flush();

Check failure on line 99 in src/EventListener/TracingConsoleListener.php

View workflow job for this annotation

GitHub Actions / PHPStan 

Function metrics not found.

Check failure on line 99 in src/EventListener/TracingConsoleListener.php

View workflow job for this annotation

GitHub Actions / Psalm

UndefinedFunction 

src/EventListener/TracingConsoleListener.php:99:13: UndefinedFunction: Function Sentry\SentryBundle\EventListener\metrics does not exist (see https://psalm.dev/021)
}
}

Expand Down
Loading