editions: Split edition definitions to own file #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EbonJaeger
force-pushed
the
move-editions-data
branch
from
f6e6f45 to
627d9c3
Compare
**Notable Changes** - React 18 -> 19 - Docusaurus 3.8.1 -> 3.9.0 - Material UI v5 -> v7 - Search plugin swapped out again because no one seems to be maintaining these things and it didn't work with newer React. We might want to consider using the official [Algolia](https://docusaurus.io/docs/3.0.1/search#using-algolia-docsearch) search. I would love to keep using a local search instead of farming it out to some other service, but.... :/ Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
EbonJaeger
force-pushed
the
move-editions-data
branch
2 times, most recently
from
363bd1e to
b58ab2c
Compare
This is what Docusaurus is still using, and using a different version causes lint failures. Ref #640 Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
EbonJaeger
force-pushed
the
move-editions-data
branch
from
b58ab2c to
ff6f7cb
Compare
Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
Right now, the data for our website is a bit spread out. People and teams live in `src/data`, but others like our editions and top-level categories live in the component and page files. Let's make everything easier to find. This moves the edition definitions to a file under `src/data`, making the component responsible only for the actual UI of the site. ~~I did this all jumbled up with #641, so it might be a good idea to merge this PR *after* that one, just in case I missed something when trying to separate all of my changes.~~ Depends on #660 Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
EbonJaeger
force-pushed
the
move-editions-data
branch
from
ff6f7cb to
592c4c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, the data for our website is a bit spread out. People and teams live in
src/data, but others like our editions and top-level categories live in the component and page files. Let's make everything easier to find. This moves the edition definitions to a file undersrc/data, making the component responsible only for the actual UI of the site.I did this all jumbled up with #641, so it might be a good idea to merge this PR after that one, just in case I missed something when trying to separate all of my changes.Depends on #660