-
Notifications
You must be signed in to change notification settings - Fork 90
Update disks.md (EFI partition size) #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
change 1 GB EFI partition size recommendation to 1 GiB (= 1024 MiB) as is Calamares requirement
There is also one more reference here:
|
If you are using a system with UEFI, you may need to create an EFI System Partition, also referred to as an ESP. This is not necessary if you are enabling Solus to install onto the entire disk. | ||
|
||
To create an EFI System Partition, open up GParted and create a FAT32 partition that is 1 GB in size. Next, right-click on the partition and click Manage Flags. On the Manage Flags section, enable the `boot` and `esp` flags. | ||
To create an EFI System Partition, open up GParted and create a FAT32 partition that is 1 GiB (= 1024 MiB) in size. Next, right-click on the partition and click Manage Flags. On the Manage Flags section, enable the `boot` and `esp` flags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To create an EFI System Partition, open up GParted and create a FAT32 partition that is 1 GiB (= 1024 MiB) in size. Next, right-click on the partition and click Manage Flags. On the Manage Flags section, enable the `boot` and `esp` flags. | |
To create an EFI System Partition, open up GParted and create a FAT32 partition that is 1 GiB (= 1024 MiB) in size. Next, right-click on the partition and click Manage Flags. On the Manage Flags section, enable the `boot` and `esp` flags. |
Please also add a non-breaking space before the new value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, maybe this should also use the same or a similar form as the table in System Requirements, for consistency's sake.
That is, something like 1.08 GB / 1 GiB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you would prefer 1.08 GB / 1 GiB / 1024 MiB
instead of 1 GiB (= 1024 MiB)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, to be honest. Someone with a sense of aesthetics please give your input! ^^
In any case this shouldn't be a hold-up for getting this clarification / error correction in, so as long as you add the non-breaking space and also add the same change to the System Requirements doc I think it should be fine to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is a tricky/interesting question.
- In
disks.md
use 1024 MiB only, don't add any equivalents or conversions (GParted shows MiB in the UI, adding the GiB conversion is not really necessary or helpful) - The tricky part comes for the system requirements. In that file, I'd say leave it as 1 GB because:
- Drives are usually rated in GB
- The exact size for the EFI partition is only relevant to people who choose to install Solus manually. That people will eventually read
disks.md
to see the exact number they need
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the first part. For the second part I'd still change it though, otherwise it's simply wrong. Perhaps only show the 1 GiB value there (because the exact GB value is ugly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's another option: Removing that line from the requirements page, like this:
- https://docs.fedoraproject.org/en-US/fedora/f39/release-notes/welcome/Hardware_Overview/
- https://help.ubuntu.com/community/Installation/SystemRequirements#Recommended_Minimum_System_Requirements
- https://support.system76.com/articles/install-pop/
The rationale: Users reading the system requirements page only need to know if their system as a whole meets the requirements to run the operating systems. The users who need to know the exact size of the EFI partition are the ones who want to install everything manually, and that kind of users will eventually land in disks.md
If you are using a system with UEFI, you may need to create an EFI System Partition, also referred to as an ESP. This is not necessary if you are enabling Solus to install onto the entire disk. | ||
|
||
To create an EFI System Partition, open up GParted and create a FAT32 partition that is 1 GB in size. Next, right-click on the partition and click Manage Flags. On the Manage Flags section, enable the `boot` and `esp` flags. | ||
To create an EFI System Partition, open up GParted and create a FAT32 partition that is 1 GiB (= 1024 MiB) in size. Next, right-click on the partition and click Manage Flags. On the Manage Flags section, enable the `boot` and `esp` flags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To create an EFI System Partition, open up GParted and create a FAT32 partition that is 1 GiB (= 1024 MiB) in size. Next, right-click on the partition and click Manage Flags. On the Manage Flags section, enable the `boot` and `esp` flags. | |
To create an EFI System Partition, open up GParted and create a FAT32 partition that is 1024 MiB in size. Next, right-click on the partition and click Manage Flags. On the Manage Flags section, enable the `boot` and `esp` flags. |
change 1 GB EFI partition size recommendation to 1 GiB (= 1024 MiB) as is Calamares requirement
Description
This pull request modifies disks.md to adjust Efi size recommendation from
1 GB
to1 GiB (= 1024 MiB)
to comply with Calamares requirements.This solves #643