Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on: [ push, pull_request_target ]

jobs:
php8-1:
name: Unit Tests php8.1 (php ${{ matrix.php-version }})
name: Unit Tests Php 8.1 (php ${{ matrix.php-version }})
runs-on: ubuntu-latest
# always run on push events
# only run on pull_request_target event when pull request pulls from fork repository
Expand Down Expand Up @@ -31,28 +31,38 @@ jobs:

- run: composer test

php8-4:
name: Unit Tests php8.4 (php ${{ matrix.php-version }})
unit-tests:
# The name is now dynamic based on the custom name set in the matrix.
name: ${{ matrix.job-name }}
runs-on: ubuntu-latest
# always run on push events
# only run on pull_request_target event when pull request pulls from fork repository
# Your original conditions for running the job are preserved.
if: >
github.event_name == 'push' ||
github.event_name == 'pull_request_target' && github.event.pull_request.head.repo.full_name != github.repository
(github.event_name == 'pull_request_target' && github.event.pull_request.head.repo.full_name != github.repository)
strategy:
fail-fast: false
matrix:
php-version: [ 8.4 ]
# Using include allows us to set custom variables for each job combination.
include:
- php-version: 8.2
job-name: "Unit Tests (PHP 8.2)"
- php-version: 8.3
job-name: "Unit Tests (PHP 8.3)"
- php-version: 8.4
job-name: "Unit Tests (PHP 8.4)"

steps:
- uses: actions/checkout@v2
# It's best practice to use the latest major version of actions.
- uses: actions/checkout@v4

- uses: shivammathur/setup-php@2.9.0
- uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-version }}
# Optional: Add extensions if needed, for example:
# extensions: mbstring, intl, gd

# Remove php-cs-fixer until compatible with PHP 8
# This step might be removable if php-cs-fixer is compatible with 8.4 by the time this runs
# This step to remove php-cs-fixer is kept from your original file.
# You may want to confirm if it's still needed for both PHP versions.
- run: composer remove --dev --no-update --no-interaction friendsofphp/php-cs-fixer

- run: composer self-update
Expand All @@ -61,6 +71,7 @@ jobs:

- run: composer test


php7-4:
name: Unit Tests php7.4 (php ${{ matrix.php-version }})
runs-on: ubuntu-latest
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,13 @@ Add the Yoti SDK dependency:

```json
"require": {
"yoti/yoti-php-sdk" : "^4.4.0"
"yoti/yoti-php-sdk" : "^4.4.1"
}
```

Or run this Composer command
```console
$ composer require yoti/yoti-php-sdk "^4.4.0"
$ composer require yoti/yoti-php-sdk "^4.4.1"
```

## Setup
Expand Down
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
{
"name": "yoti/yoti-php-sdk",
"description": "Yoti SDK for quickly integrating your PHP backend with Yoti",
"version": "4.4.0",
"version": "4.4.1",
"keywords": [
"yoti",
"sdk"
],
"homepage": "https://yoti.com",
"license": "MIT",
"require": {
"php": "^7.4 || ^8.0 || ^8.1 || ^8.4",
"php": "^7.4 || ^8.0 || ^8.1 || ^8.2 || ^8.4",
"ext-json": "*",
"google/protobuf": "^3.10",
"phpseclib/phpseclib": "^3.0",
Expand Down
2 changes: 1 addition & 1 deletion examples/doc-scan/app/Http/Controllers/HomeController.php
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public function show(Request $request, DocScanClient $client)
->withErrorUrl(config('app.url') . '/error')
->withPrivacyPolicyUrl(config('app.url') . '/privacy-policy')
->withBiometricConsentFlow('EARLY')
->withBrandId('brand_id')
//->withBrandId('brand_id')
->build()
)
->withRequiredDocument(
Expand Down
2 changes: 1 addition & 1 deletion src/Constants.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class Constants
public const SDK_IDENTIFIER = 'PHP';

/** Default SDK version */
public const SDK_VERSION = '4.4.0';
public const SDK_VERSION = '4.4.1';

/** Base url for connect page (user will be redirected to this page eg. baseurl/app-id) */
public const CONNECT_BASE_URL = 'https://www.yoti.com/connect';
Expand Down
Loading