-
Notifications
You must be signed in to change notification settings - Fork 68
Convert more dataflow queries to the new dataflow library #927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
7c7d6f6
Conver ARR32-C to use the new dataflow library
jketema 1d30fd5
Convert DCL30-C to the new dataflow library
jketema 43c96a7
Convert ERR32-C to use the new dataflow library
jketema 15b9143
Convert ERR33-C to use the new dataflow library
jketema 9ca601a
Convert EXP37-C to the new dataflow library
jketema 1309e18
Convert EXP40-C to the new dataflow library
jketema 25571ec
Convert FIO44-C to the new dataflow library
jketema 3cb8899
Convert MEM35-C to the new dataflow library
jketema f8daf8c
Convert MEM36-C to the new dataflow library
jketema 8924137
Convert SIG30-C to the new dataflow library
jketema 6865078
Convert SIG35-C to the new dataflow library
jketema 0910b4f
Convert Signal library to the new data flow library
jketema 7b5eba0
Convert RULE-13-2 to the new dataflow library
jketema dc76e3c
Convert RULE-21-14 to the new dataflow library
jketema d65bc91
Convert RULE-22-7 to the new dataflow library
jketema fc2ab4b
Convert A13-1-3 to the new dataflow library
jketema 3dae0a6
Convert A13-2-1 to the new dataflow library
jketema 2cc7388
Convert A15-1-3 to the new dataflow library
jketema 88ff741
Address review comment
jketema File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 0 additions & 2 deletions
2
c/cert/test/rules/ARR32-C/VariableLengthArraySizeNotInValidRange.expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 1 addition & 6 deletions
7
c/cert/test/rules/DCL30-C/AppropriateStorageDurationsFunctionReturn.expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,2 @@ | ||
WARNING: module 'DataFlow' has been deprecated and may be removed in future (AppropriateStorageDurationsFunctionReturn.ql:33,20-28) | ||
WARNING: module 'DataFlow' has been deprecated and may be removed in future (AppropriateStorageDurationsFunctionReturn.ql:37,31-39) | ||
WARNING: module 'DataFlow' has been deprecated and may be removed in future (AppropriateStorageDurationsFunctionReturn.ql:50,6-14) | ||
WARNING: module 'DataFlow' has been deprecated and may be removed in future (AppropriateStorageDurationsFunctionReturn.ql:50,26-34) | ||
WARNING: module 'DataFlow' has been deprecated and may be removed in future (AppropriateStorageDurationsFunctionReturn.ql:56,3-11) | ||
| test.c:3:10:3:10 | a | $@ with automatic storage may be accessible outside of its lifetime. | test.c:3:10:3:10 | a | a | | ||
| test.c:15:4:15:8 | param [inner post update] | $@ with automatic storage may be accessible outside of its lifetime. | test.c:15:12:15:13 | a2 | a2 | | ||
| test.c:12:16:12:20 | *param | $@ with automatic storage may be accessible outside of its lifetime. | test.c:15:12:15:13 | a2 | a2 | |
4 changes: 0 additions & 4 deletions
4
c/cert/test/rules/ERR32-C/DoNotRelyOnIndeterminateValuesOfErrno.expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
c/cert/test/rules/ERR33-C/DetectAndHandleStandardLibraryErrors.expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 30 additions & 18 deletions
48
c/cert/test/rules/EXP37-C/DoNotCallFunctionPointerWithIncompatibleType.expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,40 @@ | ||
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotCallFunctionPointerWithIncompatibleType.ql:45,54-62) | ||
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotCallFunctionPointerWithIncompatibleType.ql:46,22-30) | ||
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotCallFunctionPointerWithIncompatibleType.ql:50,20-28) | ||
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotCallFunctionPointerWithIncompatibleType.ql:55,43-51) | ||
edges | ||
| test.c:48:68:48:70 | fns [f1] | test.c:49:3:49:5 | fns [f1] | provenance | | | ||
| test.c:49:3:49:5 | fns [f1] | test.c:49:8:49:9 | f1 | provenance | | | ||
| test.c:61:28:61:29 | f2 | test.c:62:3:62:11 | v1_called | provenance | | | ||
| test.c:73:3:73:5 | fns [post update] [f1] | test.c:75:45:75:48 | & ... [f1] | provenance | | | ||
| test.c:73:3:73:13 | ... = ... | test.c:73:3:73:5 | fns [post update] [f1] | provenance | | | ||
| test.c:48:68:48:70 | *fns [f1] | test.c:49:3:49:5 | *fns [f1] | provenance | | | ||
| test.c:48:68:48:70 | *fns [f2] | test.c:50:3:50:5 | *fns [f2] | provenance | | | ||
| test.c:49:3:49:5 | *fns [f1] | test.c:49:8:49:9 | f1 | provenance | | | ||
| test.c:50:3:50:5 | *fns [f2] | test.c:50:8:50:9 | f2 | provenance | | | ||
| test.c:61:3:61:29 | ... = ... | test.c:62:3:62:11 | v1_called | provenance | | | ||
| test.c:61:15:61:29 | f2 | test.c:61:3:61:29 | ... = ... | provenance | | | ||
| test.c:73:3:73:5 | *fns [post update] [f1] | test.c:74:3:74:5 | *fns [f1] | provenance | | | ||
| test.c:73:3:73:13 | ... = ... | test.c:73:3:73:5 | *fns [post update] [f1] | provenance | | | ||
| test.c:73:12:73:13 | v2 | test.c:73:3:73:13 | ... = ... | provenance | | | ||
| test.c:75:45:75:48 | & ... [f1] | test.c:48:68:48:70 | fns [f1] | provenance | | | ||
| test.c:73:12:73:13 | v2 | test.c:74:3:74:13 | ... = ... | provenance | | | ||
| test.c:74:3:74:5 | *fns [f1] | test.c:75:45:75:48 | *& ... [f1] | provenance | | | ||
| test.c:74:3:74:5 | *fns [post update] [f2] | test.c:75:45:75:48 | *& ... [f2] | provenance | | | ||
| test.c:74:3:74:13 | ... = ... | test.c:74:3:74:5 | *fns [post update] [f2] | provenance | | | ||
| test.c:75:45:75:48 | *& ... [f1] | test.c:48:68:48:70 | *fns [f1] | provenance | | | ||
| test.c:75:45:75:48 | *& ... [f2] | test.c:48:68:48:70 | *fns [f2] | provenance | | | ||
nodes | ||
| test.c:48:68:48:70 | fns [f1] | semmle.label | fns [f1] | | ||
| test.c:49:3:49:5 | fns [f1] | semmle.label | fns [f1] | | ||
| test.c:48:68:48:70 | *fns [f1] | semmle.label | *fns [f1] | | ||
| test.c:48:68:48:70 | *fns [f2] | semmle.label | *fns [f2] | | ||
| test.c:49:3:49:5 | *fns [f1] | semmle.label | *fns [f1] | | ||
| test.c:49:8:49:9 | f1 | semmle.label | f1 | | ||
| test.c:61:28:61:29 | f2 | semmle.label | f2 | | ||
| test.c:50:3:50:5 | *fns [f2] | semmle.label | *fns [f2] | | ||
| test.c:50:8:50:9 | f2 | semmle.label | f2 | | ||
| test.c:61:3:61:29 | ... = ... | semmle.label | ... = ... | | ||
| test.c:61:15:61:29 | f2 | semmle.label | f2 | | ||
| test.c:62:3:62:11 | v1_called | semmle.label | v1_called | | ||
| test.c:70:9:70:17 | v3_called | semmle.label | v3_called | | ||
| test.c:73:3:73:5 | fns [post update] [f1] | semmle.label | fns [post update] [f1] | | ||
| test.c:70:4:70:17 | v3_called | semmle.label | v3_called | | ||
| test.c:73:3:73:5 | *fns [post update] [f1] | semmle.label | *fns [post update] [f1] | | ||
| test.c:73:3:73:13 | ... = ... | semmle.label | ... = ... | | ||
| test.c:73:12:73:13 | v2 | semmle.label | v2 | | ||
| test.c:75:45:75:48 | & ... [f1] | semmle.label | & ... [f1] | | ||
| test.c:74:3:74:5 | *fns [f1] | semmle.label | *fns [f1] | | ||
| test.c:74:3:74:5 | *fns [post update] [f2] | semmle.label | *fns [post update] [f2] | | ||
| test.c:74:3:74:13 | ... = ... | semmle.label | ... = ... | | ||
| test.c:75:45:75:48 | *& ... [f1] | semmle.label | *& ... [f1] | | ||
| test.c:75:45:75:48 | *& ... [f2] | semmle.label | *& ... [f2] | | ||
subpaths | ||
#select | ||
| test.c:61:28:61:29 | f2 | test.c:61:28:61:29 | f2 | test.c:62:3:62:11 | v1_called | Incompatible function $@ assigned to function pointer is eventually called through the pointer. | test.c:41:13:41:14 | f2 | f2 | | ||
| test.c:70:9:70:17 | v3_called | test.c:70:9:70:17 | v3_called | test.c:70:9:70:17 | v3_called | Incompatible function $@ assigned to function pointer is eventually called through the pointer. | test.c:58:7:58:15 | v3_called | v3_called | | ||
| test.c:61:15:61:29 | f2 | test.c:61:15:61:29 | f2 | test.c:62:3:62:11 | v1_called | Incompatible function $@ assigned to function pointer is eventually called through the pointer. | test.c:41:13:41:14 | f2 | f2 | | ||
| test.c:70:4:70:17 | v3_called | test.c:70:4:70:17 | v3_called | test.c:70:4:70:17 | v3_called | Incompatible function $@ assigned to function pointer is eventually called through the pointer. | test.c:58:7:58:15 | v3_called | v3_called | | ||
| test.c:73:12:73:13 | v2 | test.c:73:12:73:13 | v2 | test.c:49:8:49:9 | f1 | Incompatible function $@ assigned to function pointer is eventually called through the pointer. | test.c:56:7:56:8 | v2 | v2 | |
45 changes: 26 additions & 19 deletions
45
c/cert/test/rules/EXP40-C/DoNotModifyConstantObjects.expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,33 +1,40 @@ | ||
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotModifyConstantObjects.ql:40,30-38) | ||
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotModifyConstantObjects.ql:41,22-30) | ||
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotModifyConstantObjects.ql:47,20-28) | ||
WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotModifyConstantObjects.ql:52,19-27) | ||
edges | ||
| test.c:5:8:5:9 | & ... | test.c:6:4:6:5 | aa | provenance | | | ||
| test.c:26:15:26:15 | a | test.c:27:4:27:4 | a | provenance | | | ||
| test.c:5:3:5:9 | ... = ... | test.c:6:3:6:5 | * ... | provenance | | | ||
| test.c:5:8:5:9 | & ... | test.c:5:3:5:9 | ... = ... | provenance | | | ||
| test.c:26:15:26:15 | a | test.c:27:3:27:4 | * ... | provenance | | | ||
| test.c:34:13:34:14 | & ... | test.c:34:13:34:14 | & ... | provenance | | | ||
| test.c:34:13:34:14 | & ... | test.c:37:3:37:10 | ... = ... | provenance | | | ||
| test.c:34:13:34:14 | & ... | test.c:39:7:39:8 | p1 | provenance | | | ||
| test.c:37:3:37:10 | ... = ... | test.c:40:7:40:9 | * ... | provenance | | | ||
| test.c:39:7:39:8 | p1 | test.c:26:15:26:15 | a | provenance | | | ||
| test.c:40:7:40:9 | * ... | test.c:26:15:26:15 | a | provenance | | | ||
| test.c:59:7:59:8 | & ... | test.c:60:4:60:4 | p | provenance | | | ||
| test.c:79:11:79:16 | call to strchr | test.c:81:6:81:12 | ... ++ | provenance | | | ||
| test.c:59:3:59:8 | ... = ... | test.c:60:3:60:4 | * ... | provenance | | | ||
| test.c:59:7:59:8 | & ... | test.c:59:3:59:8 | ... = ... | provenance | | | ||
| test.c:79:3:79:31 | ... = ... | test.c:81:5:81:12 | * ... | provenance | | | ||
| test.c:79:11:79:16 | call to strchr | test.c:79:3:79:31 | ... = ... | provenance | | | ||
nodes | ||
| test.c:5:3:5:9 | ... = ... | semmle.label | ... = ... | | ||
| test.c:5:8:5:9 | & ... | semmle.label | & ... | | ||
| test.c:6:4:6:5 | aa | semmle.label | aa | | ||
| test.c:6:3:6:5 | * ... | semmle.label | * ... | | ||
| test.c:26:15:26:15 | a | semmle.label | a | | ||
| test.c:27:4:27:4 | a | semmle.label | a | | ||
| test.c:27:3:27:4 | * ... | semmle.label | * ... | | ||
| test.c:34:13:34:14 | & ... | semmle.label | & ... | | ||
| test.c:34:13:34:14 | & ... | semmle.label | & ... | | ||
| test.c:37:3:37:10 | ... = ... | semmle.label | ... = ... | | ||
| test.c:39:7:39:8 | p1 | semmle.label | p1 | | ||
| test.c:40:7:40:9 | * ... | semmle.label | * ... | | ||
| test.c:59:3:59:8 | ... = ... | semmle.label | ... = ... | | ||
| test.c:59:7:59:8 | & ... | semmle.label | & ... | | ||
| test.c:60:4:60:4 | p | semmle.label | p | | ||
| test.c:74:12:74:12 | s | semmle.label | s | | ||
| test.c:60:3:60:4 | * ... | semmle.label | * ... | | ||
| test.c:74:3:74:12 | * ... | semmle.label | * ... | | ||
| test.c:79:3:79:31 | ... = ... | semmle.label | ... = ... | | ||
| test.c:79:11:79:16 | call to strchr | semmle.label | call to strchr | | ||
| test.c:81:6:81:12 | ... ++ | semmle.label | ... ++ | | ||
| test.c:81:5:81:12 | * ... | semmle.label | * ... | | ||
subpaths | ||
#select | ||
| test.c:6:4:6:5 | aa | test.c:5:8:5:9 | & ... | test.c:6:4:6:5 | aa | Const variable assigned with non const-value. | | ||
| test.c:27:4:27:4 | a | test.c:34:13:34:14 | & ... | test.c:27:4:27:4 | a | Const variable assigned with non const-value. | | ||
| test.c:27:4:27:4 | a | test.c:40:7:40:9 | * ... | test.c:27:4:27:4 | a | Const variable assigned with non const-value. | | ||
| test.c:60:4:60:4 | p | test.c:59:7:59:8 | & ... | test.c:60:4:60:4 | p | Const variable assigned with non const-value. | | ||
| test.c:74:12:74:12 | s | test.c:74:12:74:12 | s | test.c:74:12:74:12 | s | Const variable assigned with non const-value. | | ||
| test.c:81:6:81:12 | ... ++ | test.c:79:11:79:16 | call to strchr | test.c:81:6:81:12 | ... ++ | Const variable assigned with non const-value. | | ||
| test.c:6:3:6:5 | * ... | test.c:5:8:5:9 | & ... | test.c:6:3:6:5 | * ... | Const variable assigned with non const-value. | | ||
| test.c:27:3:27:4 | * ... | test.c:34:13:34:14 | & ... | test.c:27:3:27:4 | * ... | Const variable assigned with non const-value. | | ||
| test.c:27:3:27:4 | * ... | test.c:40:7:40:9 | * ... | test.c:27:3:27:4 | * ... | Const variable assigned with non const-value. | | ||
| test.c:60:3:60:4 | * ... | test.c:59:7:59:8 | & ... | test.c:60:3:60:4 | * ... | Const variable assigned with non const-value. | | ||
| test.c:74:3:74:12 | * ... | test.c:74:3:74:12 | * ... | test.c:74:3:74:12 | * ... | Const variable assigned with non const-value. | | ||
| test.c:81:5:81:12 | * ... | test.c:79:11:79:16 | call to strchr | test.c:81:5:81:12 | * ... | Const variable assigned with non const-value. | |
5 changes: 0 additions & 5 deletions
5
c/cert/test/rules/FIO44-C/OnlyUseValuesForFsetposThatAreReturnedFromFgetpos.expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,2 @@ | ||
WARNING: module 'DataFlow' has been deprecated and may be removed in future (OnlyUseValuesForFsetposThatAreReturnedFromFgetpos.ql:30,32-40) | ||
WARNING: module 'DataFlow' has been deprecated and may be removed in future (OnlyUseValuesForFsetposThatAreReturnedFromFgetpos.ql:31,22-30) | ||
WARNING: module 'DataFlow' has been deprecated and may be removed in future (OnlyUseValuesForFsetposThatAreReturnedFromFgetpos.ql:33,14-22) | ||
WARNING: module 'DataFlow' has been deprecated and may be removed in future (OnlyUseValuesForFsetposThatAreReturnedFromFgetpos.ql:36,20-28) | ||
WARNING: module 'DataFlow' has been deprecated and may be removed in future (OnlyUseValuesForFsetposThatAreReturnedFromFgetpos.ql:42,21-29) | ||
| test.c:7:24:7:30 | & ... | The position argument of a call to `fsetpos()` should be obtained from a call to `fgetpos()`. | | ||
| test.c:33:24:33:30 | & ... | The position argument of a call to `fsetpos()` should be obtained from a call to `fgetpos()`. | |
2 changes: 0 additions & 2 deletions
2
c/cert/test/rules/MEM35-C/InsufficientMemoryAllocatedForObject.expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.