-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Python extractor: overlay support #20206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
d10c
wants to merge
8
commits into
github:main
Choose a base branch
from
d10c:d10c/python-overlay
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+5,176
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b054de4
to
57487f8
Compare
The new name is required by overlay support.
b18b9ce
to
3015c12
Compare
Comment on lines
+9
to
+13
/** | ||
* A local predicate that always holds for the overlay variant and | ||
* never holds for the base variant. This is used to define local | ||
* predicates that behave differently for the base and overlay variant. | ||
*/ |
Check warning
Code scanning / CodeQL
Predicate QLDoc style. Warning
The QLDoc for a predicate without a result should start with 'Holds'.
private string getRawPathForScope(@py_scope scope) { | ||
exists(@location loc | py_scope_location(loc, scope) | result = getRawPathForLocation(loc)) | ||
or | ||
result = getRawPathForModule(scope.(@py_Module)) |
Check warning
Code scanning / CodeQL
Redundant cast Warning
Redundant cast to .
@py_Module
Error loading related location
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds overlay support to the Python extractor.
Roadmap:
CODEQL_EXTRACTOR_<LANG>_OVERLAY_BASE_METADATA_{IN,OUT}
)