refactor: generalize color setting and skip detailed subject fetching when disabled #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A question: should this be defaulted on or off 🤔? Currently we default this to |
bmulholland
approved these changes
Apr 15, 2024
afonsojramos
approved these changes
Apr 15, 2024
|
Let's keep it off I suppose, until we find a way to not trigger rate-limiting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the existing
colorssettings to a more generaldetailedNotifications.When set to false, skip fetching detailed subject info for each notification (help avoid rate-limiting).
Note: I have used this setting as the example within #1006