Skip to content

refactor: use status type (loading, error, success) #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 24, 2024
Merged

refactor: use status type (loading, error, success) #1061

merged 6 commits into from
Apr 24, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Apr 23, 2024 •
edited
Loading

@setchy setchy added the refactor Refactoring of existing feature label Apr 23, 2024
@setchy setchy added this to the Release 5.5.0 milestone Apr 23, 2024
bmulholland
bmulholland approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's a nice tip! Will keep it in mind elsewhere :)

afonsojramos
afonsojramos approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy when TS is happy! 🤗

@setchy setchy merged commit 62926fc into main Apr 24, 2024
@setchy setchy deleted the refactor/status-type branch April 24, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmulholland bmulholland bmulholland approved these changes

@afonsojramos afonsojramos afonsojramos approved these changes

Assignees
No one assigned
Labels
refactor Refactoring of existing feature
Projects
None yet
Milestone
Release 5.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@setchy @bmulholland @afonsojramos