Skip to content

refactor(useNotifications): extract getNotifications into function #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2024
Merged

refactor(useNotifications): extract getNotifications into function #981

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b638348
refactor(useNotifications): extract getNotifications into function
setchy Apr 8, 2024
1e69cb7
Merge branch 'main' into refactor/usenotifications-getnotifications
setchy Apr 8, 2024
aeb169e
fix linting
setchy Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions src/hooks/useNotifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import axios from 'axios';
import axios, { type AxiosPromise } from 'axios';
import { useCallback, useState } from 'react';

import type { AccountNotifications, AuthState, SettingsState } from '../types';
Expand Down Expand Up @@ -65,24 +65,26 @@ export const useNotifications = (colors: boolean): NotificationsState => {
const fetchNotifications = useCallback(
async (accounts: AuthState, settings: SettingsState) => {
const isGitHubLoggedIn = accounts.token !== null;
const endpointSuffix = `notifications?participating=${settings.participating}`;

function getNotifications(hostname: string, token: string): AxiosPromise {
const endpointSuffix = `notifications?participating=${settings.participating}`;
const url = `${generateGitHubAPIUrl(hostname)}${endpointSuffix}`;
return apiRequestAuth(url, 'GET', token);
}

function getGitHubNotifications() {
if (!isGitHubLoggedIn) {
return;
}
const url = `${generateGitHubAPIUrl(
return getNotifications(
Constants.DEFAULT_AUTH_OPTIONS.hostname,
)}${endpointSuffix}`;
return apiRequestAuth(url, 'GET', accounts.token);
accounts.token,
);
}

function getEnterpriseNotifications() {
return accounts.enterpriseAccounts.map((account) => {
const url = `${generateGitHubAPIUrl(
account.hostname,
)}${endpointSuffix}`;
return apiRequestAuth(url, 'GET', account.token);
return getNotifications(account.hostname, account.token);
});
}

Expand Down