refactor(helper): extract isGitHubLoggedIn helper

src/hooks/useNotifications.ts

@@ -10,6 +10,7 @@ import {
   getEnterpriseAccountToken,
   getTokenForHost,
   isEnterpriseHost,
+  isGitHubLoggedIn,
 } from '../utils/helpers';
 import {
   setTrayIconColor,
@@ -64,16 +65,14 @@ export const useNotifications = (colors: boolean): NotificationsState => {
 
   const fetchNotifications = useCallback(
     async (accounts: AuthState, settings: SettingsState) => {
-      const isGitHubLoggedIn = accounts.token !== null;
-
       function getNotifications(hostname: string, token: string): AxiosPromise {
         const endpointSuffix = `notifications?participating=${settings.participating}`;
         const url = `${generateGitHubAPIUrl(hostname)}${endpointSuffix}`;
         return apiRequestAuth(url, 'GET', token);
       }
 
       function getGitHubNotifications() {
-        if (!isGitHubLoggedIn) {
+        if (!isGitHubLoggedIn(accounts)) {
           return;
         }
         return getNotifications(
@@ -111,7 +110,7 @@ export const useNotifications = (colors: boolean): NotificationsState => {
                 };
               },
             );
-            const data = isGitHubLoggedIn
+            const data = isGitHubLoggedIn(accounts)
               ? [
                   ...enterpriseNotifications,
                   {

src/utils/helpers.test.ts

@@ -17,9 +17,19 @@ import {
   generateNotificationReferrerId,
   getHtmlUrl,
   isEnterpriseHost,
+  isGitHubLoggedIn,
 } from './helpers';
 
 describe('utils/helpers.ts', () => {
+  describe('isGitHubLoggedIn', () => {
+    it('logged in', () => {
+      expect(isGitHubLoggedIn({ ...mockAccounts, token: '1234' })).toBe(true);
+    });
+
+    it('logged out', () => {
+      expect(isGitHubLoggedIn({ ...mockAccounts, token: null })).toBe(false);
+    });
+  });
   describe('isEnterpriseHost', () => {
     it('should return true for enterprise host', () => {
       expect(isEnterpriseHost('github.manos.im')).toBe(true);

src/utils/helpers.ts

@@ -13,6 +13,10 @@ import { openExternalLink } from '../utils/comms';
 import { Constants } from './constants';
 import { getCheckSuiteAttributes, getWorkflowRunAttributes } from './subject';
 
+export function isGitHubLoggedIn(accounts: AuthState): boolean {
+  return accounts.token != null;
+}
+
 export function getTokenForHost(hostname: string, accounts: AuthState): string {
   const isEnterprise = isEnterpriseHost(hostname);
   const token = isEnterprise