Skip to content

refactor: logout from #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2024
Merged

refactor: logout from #983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfc6f98
feat(settings): display username on logout hover
setchy Apr 6, 2024
f5af701
Merge branch 'main' into feature/logout-username
setchy Apr 8, 2024
758d2a6
refactor: logout from
setchy Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/routes/Settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ export const SettingsRoute: FC = () => {
>
<SignOutIcon
size={18}
aria-label={`Logout ${accounts.user.login}`}
aria-label={`Logout from ${accounts.user.login}`}
/>
</button>

Expand Down
2 changes: 1 addition & 1 deletion src/routes/__snapshots__/Settings.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ exports[`routes/Settings.tsx should render itself & its children 1`] = `
type="button"
>
<svg
aria-label="Logout octocat"
aria-label="Logout from octocat"
class="octicon octicon-sign-out"
fill="currentColor"
focusable="false"
Expand Down