Skip to content

Use configurable remote name in snippets #35172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ilya-nurullin
Copy link

@ilya-nurullin ilya-nurullin commented Jul 28, 2025

Closes #19403, and makes it possible to use any remote name in code snippets for an empty repository and pull request.
This change is very helpful to me, because I always use different name for my gitea remote.

Uses setting config module to store the value. Default is origin for backward compatibility.

Screenshots

Empty repo image
Pull Request image
Settings page image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 28, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jul 28, 2025
@lunny
Copy link
Member

lunny commented Jul 28, 2025

Maybe it should be a per repository setting but not a global one.

@ilya-nurullin
Copy link
Author

Maybe it should be a per repository setting but not a global one.

I think we can get started with a global one, and then if needed, make it more precise.
At least, the global one works well for me, and I don't need more granular settings here.

@lunny
Copy link
Member

lunny commented Jul 28, 2025

Even if you intend to add a global configuration, please store it in the database rather than in app.ini.

@ilya-nurullin
Copy link
Author

ilya-nurullin commented Jul 29, 2025

Even if you intend to add a global configuration, please store it in the database rather than in app.ini.

Done!

@silverwind silverwind added the docs-update-needed The document needs to be updated synchronously label Jul 30, 2025
@lunny lunny added this to the 1.25.0 milestone Jul 30, 2025
@lunny
Copy link
Member

lunny commented Aug 1, 2025

Does the title “Repository Snippets” in the configuration accurately reflect its purpose? It might be more appropriate under the Pull Request Settings section.

@ilya-nurullin
Copy link
Author

Does the title “Repository Snippets” in the configuration accurately reflect its purpose? It might be more appropriate under the Pull Request Settings section.

This setting affects two pages at once:

  1. Empty repo page - I believe this is the most frequent use case for the setting
  2. Pull Request page - you can do a merge using the button on the page, so snippets are hidden by default

Therefore, I would choose a more general name. I am open to any suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-update-needed The document needs to be updated synchronously lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default remote name
4 participants