Add file tree to editor #35284
Open
Add file tree to editor #35284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # templates/repo/editor/edit.tmpl # web_src/js/components/ViewFileTree.vue
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/go
|
Before adding the file tree, the commit box should be positioned in the top-right corner, similar to GitHub’s layout. The second and third pages looks strange. I think the UI needs more discussion. |
|
The delete page indeed looks a bit strange/empty. GitHub shows the delete diff, but I initially discarded the idea of implementing this as the user would have to scroll down to reach the commit box. However if the commit box is placed in the top-right this wouldn't be a problem anymore. Screenshot of the GitHub delete page
The fork page looks similar on GitHub (although your right, this also looks a bit strange) Screenshot of the GitHub fork page
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the file tree to the editor, as well as on the delete and fork page.
Editor
Delete
Edit/delete on a foreign repo
