Skip to content

refactor: use maps.Copy for cleaner map handling #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: use maps.Copy for cleaner map handling #1054

wants to merge 1 commit into from

Conversation

fengyuchuanshen
Copy link

There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.

@fengyuchuanshen
refactor: use maps.Copy for cleaner map handling
87fab58 
Signed-off-by: fengyuchuanshen <fengyuchuanshen@outlook.com>
iwpnd
iwpnd reviewed Sep 11, 2025
View reviewed changes
Copy link
Member

@iwpnd iwpnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Considering this pattern is widely used, readability is no concern in my opinion. If it would increase performance, let’s go - but I cannot imagine that it will.

gdey
gdey approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@gdey gdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@coveralls
Copy link

Pull Request Test Coverage Report for Build ac9cff933-PR-1054

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.445%
Totals Coverage Status
Change from base Build 3c9a91a1f: 0.0%
Covered Lines: 6656
Relevant Lines: 16457
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwpnd iwpnd iwpnd left review comments

@gdey gdey gdey approved these changes

@ARolek ARolek Awaiting requested review from ARolek ARolek is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fengyuchuanshen @coveralls @gdey @iwpnd