Skip to content

Conversation

@PaulTR
Copy link
Collaborator

@PaulTR PaulTR commented Oct 20, 2025

No description provided.

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:quickstarts Issues/PR referencing quickstarts folder labels Oct 20, 2025
@PaulTR PaulTR changed the title Colab update Colab update for robotics Oct 21, 2025
@Giom-V Giom-V self-requested a review October 23, 2025 11:49
@review-notebook-app
Copy link

review-notebook-app bot commented Oct 23, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-10-23T12:17:27Z
----------------------------------------------------------------

You need to decide if you want to show the code or not, and you should only use the colab @title magics for specific case when you want to hide things as those titles won't show in GitHub. I think this is such a case here.


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 23, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-10-23T12:17:28Z
----------------------------------------------------------------

I think you should explain why thinking = 0


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 23, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-10-23T12:17:29Z
----------------------------------------------------------------

Add a line to explain that you are loading the example images.


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 23, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-10-23T12:17:30Z
----------------------------------------------------------------

You should explain what pointing is


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 23, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-10-23T12:17:30Z
----------------------------------------------------------------

Explain the difference with the previous case.


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 23, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-10-23T12:17:31Z
----------------------------------------------------------------

I think the explanation would be better as text than as a comment


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 23, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-10-23T12:17:32Z
----------------------------------------------------------------

I think you should really explain in detail what's the difference with the previous cases


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 23, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-10-23T12:17:33Z
----------------------------------------------------------------

Add an explanation about what your doing (IIUC extracting the frames from the GIF and sending them to the model)


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 23, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-10-23T12:17:33Z
----------------------------------------------------------------

I think a minimal explanation on what bounding boxes and what the format is needed (just copy the one from the spatial understanding notbook). Also explain that you are loading more example images.


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 23, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-10-23T12:17:34Z
----------------------------------------------------------------

Explain what trajectories are


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 23, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-10-23T12:17:35Z
----------------------------------------------------------------

I think you need to remove the  @title here


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 23, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-10-23T12:17:35Z
----------------------------------------------------------------

Explain what's added compared to the previous case


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 23, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-10-23T12:17:36Z
----------------------------------------------------------------

Explain what spatial reasoning is.


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 23, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-10-23T12:17:36Z
----------------------------------------------------------------

I think video analysis should be a higher title and needs an introductory explanation.


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 23, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-10-23T12:17:37Z
----------------------------------------------------------------

Why are we back to simple image understanding while we were reviewing videos? I think this section and the next one should be moved somewhere else.


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 23, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-10-23T12:17:38Z
----------------------------------------------------------------

Explain why you are suddenly enabling thinking. What's special in this use-case? (also explain that thinking=-1 means thinking with automatic budget)


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 23, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-10-23T12:17:39Z
----------------------------------------------------------------

Why are you suddenly loading new images without a new section or explanation? Maybe you should group all the wget together at the beginning?

Other possibility, add a "Multi-view" section and explain what it is (you should do taht anyway)


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 23, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-10-23T12:17:39Z
----------------------------------------------------------------

Explain what code execution is and link to the relevant notebook


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 23, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-10-23T12:17:40Z
----------------------------------------------------------------

Explain what segmentation is and maybe link to the relevant notebook


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 23, 2025

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2025-10-23T12:17:41Z
----------------------------------------------------------------

Add links to the spatial understanding and spatial 3d notebooks


@Giom-V
Copy link
Collaborator

Giom-V commented Oct 30, 2025

Considering the length of the notebook, we should add a table of content and <a name="foo" /> hidden links. Check how Mark and I did in on his new datasets notebook.
Also you'll need to find a way to keep it under 19M...

@PaulTR
Copy link
Collaborator Author

PaulTR commented Oct 30, 2025

So we ended up with a robotics-samples repo. I think I'm going to break this one into multiple smaller colabs there, then use this as a table of contents.

@PaulTR PaulTR closed this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:quickstarts Issues/PR referencing quickstarts folder status:awaiting review PR awaiting review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants