Skip to content

Conversation

@Aarchi-07
Copy link

  • Converted the original Python notebook into JavaScript.
  • Added proper structure and formatting for better readability.
  • Verified code compatibility and tested basic functionality.

@github-actions github-actions bot added the status:awaiting review PR awaiting review from a maintainer label Oct 29, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Aarchi-07, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new quickstart guide for the Gemini API, specifically demonstrating streaming capabilities in JavaScript. It serves as a direct conversion from an existing Python notebook, ensuring developers can easily understand and implement streaming responses using the JavaScript SDK. The notebook includes examples for basic streaming and asynchronous handling, along with setup instructions for the API key.

Highlights

  • New JavaScript Streaming Quickstart: A new notebook, 'Streaming Quickstart.txt', has been added to demonstrate streaming capabilities of the Gemini API using the JavaScript SDK.
  • Python to JavaScript Conversion: The content of this new quickstart guide is a direct conversion from an existing Python notebook, making it easier for JavaScript developers to adopt streaming.
  • Asynchronous Streaming Examples: The notebook includes practical examples showcasing how to use generateContentStream and handle streaming responses asynchronously, ensuring applications remain responsive.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a JavaScript quickstart for streaming, which is a great addition. I have a few general suggestions:

  • The file is named Streaming Quickstart.txt. To be consistent with other files in the quickstarts-js directory, it should probably be a JavaScript file, for example Streaming.js or Streaming_Quickstart.js.
  • The repository's style guide mentions that new notebooks should be added to the corresponding README.md file. This new quickstart is missing from quickstarts-js/README.md.

I've also added a couple of specific comments to improve the code quality by declaring variables properly and fixing a potential bug where undefined could be printed to the console.

});

for await (const chunk of response) {
console.log(chunk.text);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

If a streamed chunk does not have a text property, console.log(chunk.text) will print undefined to the console. To make the code more robust, you should check for the existence of chunk.text before logging it. A short-circuit conditional is a concise way to do this, and this pattern is used correctly in the asynchronous example later in the file.

  chunk.text && console.log(chunk.text);

Comment on lines +41 to +45
module = await import("https://esm.sh/@google/genai@1.4.0");
GoogleGenAI = module.GoogleGenAI;
ai = new GoogleGenAI({ apiKey: process.env.GEMINI_API_KEY });

MODEL_ID = "gemini-2.5-flash" // ["gemini-2.5-flash-lite", "gemini-2.5-flash", "gemini-2.5-pro"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In JavaScript, it's a best practice to declare all variables with const, let, or var to define their scope and prevent them from becoming implicit global variables. This improves code predictability and maintainability.

I suggest using const for these variables since they are not reassigned. I've also used object destructuring to import GoogleGenAI, which is a more modern and concise syntax.

const module = await import("https://esm.sh/@google/genai@1.4.0");
const { GoogleGenAI } = module;
const ai = new GoogleGenAI({ apiKey: process.env.GEMINI_API_KEY });

const MODEL_ID = "gemini-2.5-flash" // ["gemini-2.5-flash-lite", "gemini-2.5-flash", "gemini-2.5-pro"]

Comment on lines +55 to +58
response = await ai.models.generateContentStream({
model: MODEL_ID,
contents: "Tell me a story in 300 words.",
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To avoid creating an implicit global variable, it's best to declare response using const since it's not reassigned.

const response = await ai.models.generateContentStream({
  model: MODEL_ID,
  contents: "Tell me a story in 300 words.",
});

@Aarchi-07 Aarchi-07 changed the title Added Streaming.ipynb notebook to JavaScript Added Streaming.ipynb notebook for JavaScript Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:awaiting review PR awaiting review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant