Skip to content

Conversation

@markmcd
Copy link
Member

@markmcd markmcd commented Nov 12, 2025

Covers all of the main features, including generation and CRUD for documents and file stores.

@markmcd markmcd requested a review from Giom-V November 12, 2025 07:39
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:quickstarts Issues/PR referencing quickstarts folder labels Nov 12, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @markmcd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new quickstart guide for the File Search API, designed to help users integrate hosted RAG systems with Gemini. The guide provides practical, step-by-step instructions and code examples for setting up file search stores, managing documents within them, and utilizing these stores to ground AI model generations with specific data, complete with metadata filtering capabilities.

Highlights

  • New File Search Cookbook: A comprehensive cookbook has been added for the File Search API, demonstrating its capabilities for Retrieval-Augmented Generation (RAG) applications.
  • Core Features Covered: The new cookbook covers essential features including the creation and management (CRUD) of File Search Stores and documents, uploading and importing files, and using these stores for content generation with accurate citations.
  • Metadata Filtering: The cookbook illustrates how to leverage custom metadata for filtering search results, enabling more precise data retrieval during content generation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new cookbook for the File Search API, which is a great addition. The notebook is well-structured and covers the main features like creating stores, uploading documents, generating content with search, and managing resources. I've found a few issues, including one critical bug in the cleanup step and a couple of medium-severity points related to style guide adherence and notebook robustness. My detailed comments are below.

@markmcd
Copy link
Member Author

markmcd commented Nov 13, 2025

PTAL!

@Giom-V Giom-V merged commit 3af5866 into google-gemini:main Nov 13, 2025
5 checks passed
@mrinalghoshh mrinalghoshh self-assigned this Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:quickstarts Issues/PR referencing quickstarts folder status:awaiting review PR awaiting review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants