-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Adds a cookbook for File Search #1034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Summary of ChangesHello @markmcd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new quickstart guide for the File Search API, designed to help users integrate hosted RAG systems with Gemini. The guide provides practical, step-by-step instructions and code examples for setting up file search stores, managing documents within them, and utilizing these stores to ground AI model generations with specific data, complete with metadata filtering capabilities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new cookbook for the File Search API, which is a great addition. The notebook is well-structured and covers the main features like creating stores, uploading documents, generating content with search, and managing resources. I've found a few issues, including one critical bug in the cleanup step and a couple of medium-severity points related to style guide adherence and notebook robustness. My detailed comments are below.
|
PTAL! |
Covers all of the main features, including generation and CRUD for documents and file stores.