Skip to content

added consistency in embed model names #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added consistency in embed model names #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google/generativeai/embedding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
from google.generativeai.types import text_types
from google.generativeai.types import content_types

DEFAULT_EMB_MODEL = "models/embedding-001"
DEFAULT_EMB_MODEL = "embedding-001"
EMBEDDING_MAX_BATCH_SIZE = 100

EmbeddingTaskType = protos.TaskType
Expand Down
4 changes: 2 additions & 2 deletions samples/embed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def test_embed_content(self):

text = "Hello World!"
result = genai.embed_content(
model="models/text-embedding-004", content=text, output_dimensionality=10
model="text-embedding-004", content=text, output_dimensionality=10
)
print(result["embedding"])
# [END embed_content]
Expand All @@ -37,7 +37,7 @@ def batch_embed_contents(self):
"How does the brain work?",
]
result = genai.embed_content(
model="models/text-embedding-004", content=texts, output_dimensionality=10
model="text-embedding-004", content=texts, output_dimensionality=10
)
print(result)
# [END batch_embed_contents]
Expand Down
2 changes: 1 addition & 1 deletion tests/test_embedding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
from absl.testing import absltest
from absl.testing import parameterized

DEFAULT_EMB_MODEL = "models/embedding-001"
DEFAULT_EMB_MODEL = "embedding-001"


class UnitTests(parameterized.TestCase):
Expand Down
2 changes: 1 addition & 1 deletion tests/test_embedding_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
from absl.testing import absltest
from absl.testing import parameterized

DEFAULT_EMB_MODEL = "models/embedding-001"
DEFAULT_EMB_MODEL = "embedding-001"


class AsyncTests(parameterized.TestCase, unittest.IsolatedAsyncioTestCase):
Expand Down