Skip to content

fix: Change UsageItem.Quantity from int to float64 #3610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025

Conversation

DocEmmetBrown
Copy link
Contributor

@DocEmmetBrown DocEmmetBrown commented Jun 27, 2025

The API doc is not consistent with the actual output from the api.
The quantity is not an int, but a float.

Follows #3605

@gmlewis
Copy link
Collaborator

gmlewis commented Jun 27, 2025

Please rebase to master and try again. Also, please change the PR title to: fix: Change XXX from int to float64.

The API doc is not consistent with the actual output from the api.
The quantity is not an int, but a float.
@DocEmmetBrown DocEmmetBrown force-pushed the guillaume/fix-extended-billing branch from 7cdf4e8 to 34ba363 Compare June 27, 2025 14:20
@DocEmmetBrown DocEmmetBrown changed the title fix: quantity being a float and not an int fix: Change quantity from int to float64 Jun 27, 2025
@DocEmmetBrown
Copy link
Contributor Author

DocEmmetBrown commented Jun 27, 2025

Please rebase to master and try again.

sorry for the mess. I didn't pay attention, and forgot to rebase 🤦 . Friday afternoon is hitting hard :)

@alexandear
Copy link
Contributor

Even better title fix: Change UsageItem.Quantity from int to float64

And in the PR description we could add "Follows #3605"

@DocEmmetBrown
Copy link
Contributor Author

related to github/docs#39074

@DocEmmetBrown DocEmmetBrown changed the title fix: Change quantity from int to float64 fix: Change UsageItem.Quantity from int to float64 Jun 27, 2025
@DocEmmetBrown
Copy link
Contributor Author

Even better title fix: Change UsageItem.Quantity from int to float64

And in the PR description we could add "Follows #3605"

done 👍

@gmlewis
Copy link
Collaborator

gmlewis commented Jun 27, 2025

Just FYI... I'm not going to mark this as a breaking API change since this was originally introduced within the same major release cycle.

@gmlewis
Copy link
Collaborator

gmlewis commented Jun 27, 2025

Please fix the tests.

Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (0c6bd91) to head (65cc94e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3610   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files         184      184           
  Lines       16166    16166           
=======================================
  Hits        14765    14765           
  Misses       1227     1227           
  Partials      174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @DocEmmetBrown and @alexandear!
LGTM.
Merging.

@gmlewis gmlewis merged commit 2d29661 into google:master Jun 30, 2025
7 checks passed
@DocEmmetBrown DocEmmetBrown deleted the guillaume/fix-extended-billing branch June 30, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants