-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: Change UsageItem.Quantity from int to float64 #3610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Change UsageItem.Quantity from int to float64 #3610
Conversation
Please rebase to master and try again. Also, please change the PR title to: |
The API doc is not consistent with the actual output from the api. The quantity is not an int, but a float.
7cdf4e8
to
34ba363
Compare
sorry for the mess. I didn't pay attention, and forgot to rebase 🤦 . Friday afternoon is hitting hard :) |
Even better title And in the PR description we could add "Follows #3605" |
related to github/docs#39074 |
done 👍 |
Just FYI... I'm not going to mark this as a breaking API change since this was originally introduced within the same major release cycle. |
Please fix the tests. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3610 +/- ##
=======================================
Coverage 91.33% 91.33%
=======================================
Files 184 184
Lines 16166 16166
=======================================
Hits 14765 14765
Misses 1227 1227
Partials 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @DocEmmetBrown and @alexandear!
LGTM.
Merging.
The API doc is not consistent with the actual output from the api.
The quantity is not an int, but a float.
Follows #3605