Fix compilation errors with C++17 feature #1260
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Or change to C++17 or C++20 instead, like other PRs have done |
l0rinc
reviewed
Apr 3, 2025
| @@ -874,7 +874,7 @@ class SingletonEnv { | |||
| #endif // !defined(NDEBUG) | |||
| static_assert(sizeof(env_storage_) >= sizeof(EnvType), | |||
| "env_storage_ will not fit the Env"); | |||
| static_assert(std::is_standard_layout_v<SingletonEnv<EnvType>>); | |||
| static_assert(std::is_standard_layout<SingletonEnv<EnvType>>::value); | |||
There was a problem hiding this comment.
You likely need the message as well to be C++11 compatible
Suggested change
| static_assert(std::is_standard_layout<SingletonEnv<EnvType>>::value); | |
| static_assert(std::is_standard_layout<SingletonEnv<EnvType>>::value, | |
| "SingletonEnv<EnvType> is not standard layout"); |
There was a problem hiding this comment.
There was a problem hiding this comment.
ok, haven't seen it before, close this now.
Not all applications using LevelDB support C++17 or higher I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation errors with C++17 feature "std::is_standard_layout_v", as the default CMAKE_CXX_STANDARD is C++11, we can change to a compatible implementation.
Related issue #1247 and PR #1246