Skip to content

Default to using self.cancellation_manager #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2022
Merged

Default to using self.cancellation_manager #115

merged 2 commits into from
Sep 7, 2022

Conversation

Northbadge
Copy link
Contributor

Part of #96

@Northbadge Northbadge requested a review from mtrofin August 19, 2022 22:37
mtrofin
mtrofin reviewed Aug 19, 2022
View reviewed changes
compiler_opt/rl/inlining/inlining_runner.py Outdated
cancelled work.
RuntimeError: if llvm-size produces unexpected output.
"""
if cancellation_manager is None:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why even pass it as an arg, why not we remove it from the arglist and use self._cancellation_manager?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it, prob should check with yundi@ to see if that's an ok thing to do

@Northbadge Northbadge requested a review from yundiqian August 19, 2022 22:58
@Northbadge Northbadge mentioned this pull request Aug 19, 2022
Open
@mtrofin mtrofin merged commit 3a31367 into google:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrofin mtrofin mtrofin left review comments

@yundiqian yundiqian Awaiting requested review from yundiqian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Northbadge @mtrofin