fix(bindings): use correct query parameter for DetermineVersion endpoint #4314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuixq
changed the title
michaelkedar
previously approved these changes
Nov 5, 2025
Ly-Joey
previously approved these changes
Nov 5, 2025
michaelkedar
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
ExperimentalDetermineVersionfunction.Previously, the entire
api.DetermineVersionParametersstruct was passed as the request body, however the API endpoint expects the nestedQueryobject instead. This change fixes it by passingquery.Queryto the request, aligning it with the intended API usage.The bug was not caught in the test because we don't have actual testing for it... https://github.com/google/osv.dev/blob/master/bindings/go/osvdev/osvdev_test.go#L422