Add multi inline adaptive banner example with recycling #1316
+143
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LTPhantom
requested changes
May 14, 2025
packages/google_mobile_ads/example/lib/multi_adaptive_inline_with_recycle_example.dart
Outdated
Show resolved
Hide resolved
LTPhantom
reviewed
May 28, 2025
There was a problem hiding this comment.
dart analysis is complaining:
info • Missing documentation for a public member • example/lib/multi_adaptive_inline_with_recycle_example.dart:6:7 • public_member_api_docs
info • Missing documentation for a public member • example/lib/multi_adaptive_inline_with_recycle_example.dart:7:9 • public_member_api_docs
info • Unnecessary use of double quotes • example/lib/multi_adaptive_inline_with_recycle_example.dart:26:[11](https://github.com/googleads/googleads-mobile-flutter/actions/runs/15032701390/job/42644443675?pr=1316#step:6:12) • prefer_single_quotes
info • Unnecessary use of double quotes • example/lib/multi_adaptive_inline_with_recycle_example.dart:94:55 • prefer_single_quotes
Please fix.
Samples format error seems unrelated... will need to update on different PR.
packages/google_mobile_ads/example/lib/multi_adaptive_inline_with_recycle_example.dart
Outdated
Show resolved
Hide resolved
packages/google_mobile_ads/example/lib/multi_adaptive_inline_with_recycle_example.dart
Outdated
Show resolved
Hide resolved
packages/google_mobile_ads/example/lib/multi_adaptive_inline_with_recycle_example.dart
Outdated
Show resolved
Hide resolved
LTPhantom
reviewed
Jun 2, 2025
hellohuanlin
force-pushed
the
example_multi_adaptive_banners_recycle
branch
from
e2884a1 to
c38ee7e
Compare
Updated. Could you kick off the CI run again? Thanks! |
malandr2
requested changes
Jun 5, 2025
packages/google_mobile_ads/example/lib/multi_adaptive_inline_with_recycle_example.dart
Outdated
Show resolved
Hide resolved
packages/google_mobile_ads/example/lib/multi_adaptive_inline_with_recycle_example.dart
Outdated
Show resolved
Hide resolved
packages/google_mobile_ads/example/lib/multi_adaptive_inline_with_recycle_example.dart
Outdated
Show resolved
Hide resolved
packages/google_mobile_ads/example/lib/multi_adaptive_inline_with_recycle_example.dart
Outdated
Show resolved
Hide resolved
packages/google_mobile_ads/example/lib/multi_adaptive_inline_with_recycle_example.dart
Outdated
Show resolved
Hide resolved
packages/google_mobile_ads/example/lib/multi_adaptive_inline_with_recycle_example.dart
Outdated
Show resolved
Hide resolved
|
Is there any way to preload ads for banner (small, mrec & adaptive). I can found same in applovin sdk - https://developers.axon.ai/en/max/flutter/ad-formats/banner-and-mrec-ads#ad-preloading |
malandr2
approved these changes
Jun 22, 2025
| size: adSize, | ||
| listener: BannerAdListener( | ||
| onAdLoaded: (Ad ad) async { | ||
| BannerAd bannerAd = (ad as BannerAd); |
There was a problem hiding this comment.
Can we include onAdFailed to load callback?
| adUnitId: bannerId, | ||
| request: const AdRequest(), | ||
| size: adSize, | ||
| listener: BannerAdListener( |
There was a problem hiding this comment.
Can we also include the onAdimpression callback?
| class _MultiInlineAdaptiveWithRecycleExampleState | ||
| extends State<MultiInlineAdaptiveWithRecycleExample> { | ||
| // A list of all the banners created. | ||
| final List<BannerAd> _banners = []; |
There was a problem hiding this comment.
What about failed banner ads? Do we need to keep an array of failed banners so the recycler can attempt to retry any failed banners?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This example shows how to do recycling with multiple inline adaptive banners.
It will be linked from the website: https://developers.google.com/admob/flutter/banner/inline-adaptive
Screen recording demo: flutter/flutter#158944 (comment)
Picture showing how recycle works (this PR):
No recycle for comparison:
Related Issues
flutter/flutter#158944
*Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?