-
Notifications
You must be signed in to change notification settings - Fork 2
plugin v2 preview #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
ec70e6e
to
e6fc00f
Compare
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
@jmattheis Can you take a look when you have time before I do the server side integration? I think basic functionality and consistency tests should be all there. |
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
I will leave the V1 plugin compatibility shim testing part suggestion to the next round in case there are disagreements about architecture, etc. |
There are still some open discussions and I've unresolved one discussion which doesn't seem fixed yet, but this is only minor stuff, so from the architecture side this looks good. |
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
I am starting to think about implementing auth plugins by allowing plugins to create and revoke user sessions, this can close some tickets about pluggable authentications. wdyt? A broad idea would be just give the plugin a session signing key and expose a public API like /auth/exchange-code (or even just a temporary password) that exchanges a plugin endorsement with a real token. |
I think oidc will cover most of the cases and there are already many services that proxy to oidc if you f.ex have a ldap server. I'm not sure if it's worth to implement the api for this, as we have to support this in android and this could be pretty difficult if it's generic. Either way, this should be done separately from this migration. |
Okay, I will open a concurrent PR on notify/website for plugin writing then and then the server side integration |
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
very much WIP, expect big changes as I go.
Just sharing to get some early opinions.
TODO: