Skip to content

Conversation

ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Aug 25, 2025

in line with modern design standards for AI chat apps

…yle, in line with modern design standards for AI chat apps
@ErikBjare ErikBjare changed the title design: changes the style of assistant messages to not have a card st… design: changes the style of assistant messages to not have a card style Aug 25, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to aea7c1c in 1 minute and 27 seconds. Click for details.
  • Reviewed 78 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/components/ChatMessage.tsx:180
  • Draft comment:
    User messages now include 'px-3 py-1.5' and 'border'. Ensure this spacing and border styling is consistent with the overall design.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 30% <= threshold 50% The comment is asking the author to ensure consistency with the overall design, which is similar to asking them to double-check or confirm something. This violates the rule against asking the author to confirm or ensure things. However, it does point out a specific change in styling, which could be useful if it were rephrased to suggest checking for consistency without directly asking the author to ensure it.
2. src/components/ChatMessage.tsx:182
  • Draft comment:
    Assistant messages are now rendered with only 'text-foreground' (background and padding removed). Verify if this simplified styling is intentional.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
3. src/components/ChatMessage.tsx:185
  • Draft comment:
    System messages now include 'px-3 py-1.5', 'font-mono', and 'rounded-lg'. Confirm that these new paddings and rounded corners meet the design requirements for system messages.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to confirm that the design changes meet the requirements, which is against the rules. It does not provide a specific suggestion or point out a potential issue with the code itself.
4. src/components/ChatMessage.tsx:191
  • Draft comment:
    The default case now returns an empty string instead of 'bg-card'. Ensure that fallback styling is handled as intended.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
5. src/components/ChatMessage.tsx:198
  • Draft comment:
    Removed the extra 'border' class appended at the end of the class string. Confirm that border styling is now fully managed within each role condition.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
6. src/components/ChatMessage.tsx:221
  • Draft comment:
    Removed the extra wrapper div with 'px-3 py-1.5' around the message content and files. Ensure that spacing is now consistently applied via messageClasses$ or other containers.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is suggesting to ensure that spacing is consistently applied after a change was made. It is indirectly asking the author to double-check the spacing, which violates the rule against asking the author to ensure behavior is intended or tested. Therefore, this comment should be removed.

Workflow ID: wflow_Bgw1eSn7wFJ2L48A

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant