chore(tests): ApplySuccessful conditions
#2089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baarsgaard
force-pushed
the
chore_e2e_to_testcontainers
branch
from
07050b0 to
8327f58
Compare
Baarsgaard
force-pushed
the
chore_test_synchronized_conditions
branch
from
64ca96e to
f5d073f
Compare
Baarsgaard
force-pushed
the
chore_e2e_to_testcontainers
branch
from
8327f58 to
a6bf4d8
Compare
Baarsgaard
force-pushed
the
chore_test_synchronized_conditions
branch
from
f5d073f to
158e7e3
Compare
Baarsgaard
force-pushed
the
chore_test_synchronized_conditions
branch
from
879c658 to
1e3c7b4
Compare
Baarsgaard
requested review from
nissessenap,
weisdd,
ishanjainn,
theSuess,
hubeadmin and
pb82
as code owners
Baarsgaard
force-pushed
the
chore_test_synchronized_conditions
branch
from
1e3c7b4 to
cb1ce9d
Compare
weisdd
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ApplySuccessfulto all resource controllers.Additionally, it synchronizes the
pre-existingGrafanaFolderinto the Grafana testcontainer so it's available to all controller tests.Previously a
apply-failed-helperGrafanaFolderwas created but not synchronized.Coverage of controllers has gone from
42.2%to52.6%