Skip to content

fix(Grafana): .spec.config.security.admin_* as fallback for external instances #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2025
Merged

fix(Grafana): .spec.config.security.admin_* as fallback for external instances #2092

merged 3 commits into from
Jul 25, 2025

Conversation

Baarsgaard
Copy link
Collaborator

@Baarsgaard Baarsgaard commented Jul 21, 2025 •
edited
Loading

This allows using the .spec.config as a source of credentials for external instances.

@Baarsgaard Baarsgaard changed the title fix(Grafana): .spec.config.security.admin_* as fallback for External instances fix(Grafana): .spec.config.security.admin_* as fallback for external instances Jul 21, 2025
@github-actions github-actions bot added the bugfix this PR fixes a bug label Jul 21, 2025
@Baarsgaard Baarsgaard mentioned this pull request Jul 21, 2025
Merged
@theSuess
Copy link
Collaborator

If possible, warn users about this functionality using validation logic as it's not recommended

weisdd
weisdd requested changes Jul 21, 2025
View reviewed changes
@Baarsgaard Baarsgaard force-pushed the fix_external_grafana_config_credentials_fallback branch from a443932 to 78b6d9c Compare July 23, 2025 16:05
@Baarsgaard Baarsgaard force-pushed the fix_external_grafana_config_credentials_fallback branch from 78b6d9c to 79f96b6 Compare July 23, 2025 16:14
@Baarsgaard Baarsgaard force-pushed the fix_external_grafana_config_credentials_fallback branch from 79f96b6 to 2f10f00 Compare July 23, 2025 16:18
@Baarsgaard Baarsgaard marked this pull request as ready for review July 23, 2025 16:25
@Baarsgaard Baarsgaard requested a review from weisdd July 23, 2025 16:25
@Baarsgaard
Copy link
Collaborator Author

Baarsgaard commented Jul 23, 2025 •
edited
Loading

I don't think it's possible to implement warnings on specific fields when using a CRD.
All I can find is the option to deprecate an entire spec/version of a CRD and issues discussing it in Kubernetes and kubebuilder.

weisdd
weisdd approved these changes Jul 25, 2025
View reviewed changes
Copy link
Collaborator

@weisdd weisdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behaviour-wise, it should be OK. I do have a few recommendations around test refactoring, but I'll rather open another PR addressing that to unblock this and the dependent PR.

@Baarsgaard Baarsgaard added this pull request to the merge queue Jul 25, 2025
Merged via the queue into master with commit 4a8a17e Jul 25, 2025
16 checks passed
@Baarsgaard Baarsgaard deleted the fix_external_grafana_config_credentials_fallback branch July 25, 2025 15:32
@weisdd weisdd mentioned this pull request Jul 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weisdd weisdd weisdd approved these changes

@nissessenap nissessenap Awaiting requested review from nissessenap nissessenap is a code owner

@ishanjainn ishanjainn Awaiting requested review from ishanjainn ishanjainn is a code owner

@theSuess theSuess Awaiting requested review from theSuess theSuess is a code owner

@hubeadmin hubeadmin Awaiting requested review from hubeadmin hubeadmin is a code owner

@pb82 pb82 Awaiting requested review from pb82 pb82 is a code owner

Assignees
No one assigned
Labels
bugfix this PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Baarsgaard @theSuess @weisdd