Move search index update to background #639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR moves the search index update process to a background task to improve request responsiveness and decouple the indexing process from the main transaction flow.
- Introduces a new Celery task, update_search_indices_from_transaction, to update search indices asynchronously.
- Replaces synchronous index updates in resource endpoints with run_task calls.
- Adjusts JWT tree retrieval to use get_tree_from_jwt_or_fail for improved robustness.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gramps_webapi/api/tasks.py | Adds a new background task for updating search indices. |
| gramps_webapi/api/resources/objects.py | Updates object resource to run the search index update task. |
| gramps_webapi/api/resources/base.py | Replaces synchronous index updates with asynchronous task calls and updates type hints. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Realized that existing unit tests in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #619.
Unit test missing.